Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-09 Thread Martin Gräßlin
On July 8, 2015, 7:52 p.m., Hrvoje Senjan wrote: src/pluginwrapper.cpp, line 68 https://git.reviewboard.kde.org/r/124220/diff/2/?file=382200#file382200line68 After updating to latest master, i wonder do we need this debug enabled by default? :D In the case of kglobalaccel it

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82237 --- src/pluginwrapper.cpp (line 68)

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82168 --- Seems kwindowsystem master doesn't build now (against Qt 5.5

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated July 7, 2015, 11:31 a.m.) Status -- This change has been

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-07 Thread Aleix Pol Gonzalez
On July 7, 2015, 2:16 p.m., Hrvoje Senjan wrote: Seems kwindowsystem master doesn't build now (against Qt 5.5 at least): ``` [ 55s] In file included from /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:21:0: [ 55s]

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated July 2, 2015, 8:19 a.m.) Review request for KDE Frameworks.

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review81979 --- +1 - Aleix Pol Gonzalez On July 2, 2015, 8:19 a.m., Martin

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review81943 --- src/platforms/wayland/CMakeLists.txt (line 15)

Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- Review request for KDE Frameworks. Repository: kwindowsystem