Re: Review Request 124397: Add today button to calendar

2016-02-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review92067 --- And sorry for keeping you hanging there for so long :) - Kai

Re: Review Request 124397: Add today button to calendar

2016-02-04 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Feb. 4, 2016, 8:30 nachm.) Status -- This change has been d

Re: Review Request 124397: Add today button to calendar

2015-08-03 Thread Martin Klapetek
> On July 28, 2015, 10:37 p.m., Martin Klapetek wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149 > > > > > > Given this is only used here, would it make more sense to actually move

Re: Review Request 124397: Add today button to calendar

2015-07-29 Thread Bernhard Friedreich
> On Juli 28, 2015, 8:37 nachm., Martin Klapetek wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149 > > > > > > Given this is only used here, would it make more sense to actually move

Re: Review Request 124397: Add today button to calendar

2015-07-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review83118 --- src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 7

Re: Review Request 124397: Add today button to calendar

2015-07-28 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 28, 2015, 8:32 nachm.) Review request for KDE Frameworks an

Re: Review Request 124397: Add today button to calendar

2015-07-28 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 28, 2015, 8:21 nachm.) Review request for KDE Frameworks an

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
> On Juli 19, 2015, 7:59 nachm., Kai Uwe Broulik wrote: > > +1 from my side > > > > Looking really nice, I wonder why I didn't think of this earlier :) thanks :) I'll wait for your patches to land and then rebase/push :) - Bernhard ---

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82663 --- +1 from my side Looking really nice, I wonder why I didn't th

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:06 nachm.) Review request for KDE Frameworks an

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
> On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote: > > Please include a screenshot for UI changes. > > > > Also please wait until Review 122488 is merged to save me another rebase > > headache. Of course :) I'll wait till your Review is merged. Just wanted to get some comments if I'm on

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:04 nachm.) Review request for KDE Frameworks an

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82653 --- Please include a screenshot for UI changes. Also please wait

Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bug