Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-10-03 Thread David Edmundson
> On Sept. 27, 2015, 8:21 a.m., Sune Vuorela wrote: > > src/knotifyconfigwidget.h, line 73 > > > > > > This function name for a setter looks weird to me. > > setDefaults() > > reset() > >

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-10-03 Thread David Faure
> On Sept. 27, 2015, 8:21 a.m., Sune Vuorela wrote: > > src/knotifyconfigwidget.h, line 73 > > > > > > This function name for a setter looks weird to me. > > setDefaults() > > reset() > >

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-09-27 Thread David Edmundson
> On Sept. 27, 2015, 8:21 a.m., Sune Vuorela wrote: > > src/knotifyconfigwidget.h, line 73 > > > > > > This function name for a setter looks weird to me. > > setDefaults() > > reset() > >

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-09-27 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125418/#review86002 --- src/knotifyconfigwidget.h (line 73)

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-09-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125418/ --- (Updated Sept. 26, 2015, 11:29 p.m.) Review request for KDE Frameworks.

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-09-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125418/#review85999 --- Ship it! Ship It! - Martin Klapetek On Sept. 27, 2015,

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

2015-09-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125418/ --- (Updated Sept. 27, 2015, 12:42 a.m.) Status -- This change has been