Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-06 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- (Updated Oct. 6, 2015, 8:30 a.m.) Status -- This change has been mar

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-04 Thread Frank Reininghaus
> On Okt. 3, 2015, 8:08 vorm., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defin

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-03 Thread David Faure
> On Oct. 3, 2015, 8:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defini

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-03 Thread Hrvoje Senjan
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defin

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-03 Thread Luigi Toscano
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defin

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- I just realized another problem with this approach: since the

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-03 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- (Updated Okt. 3, 2015, 7:50 vorm.) Review request for KDE Frameworks and

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-09-30 Thread Frank Reininghaus
> On Sept. 28, 2015, 7:30 vorm., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-09-30 Thread David Faure
> On Sept. 28, 2015, 7:30 a.m., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both a

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-09-29 Thread Frank Reininghaus
> On Sept. 28, 2015, 7:30 vorm., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- The filename not matching the servicetype name in it, is very

Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-09-27 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- Review request for KDE Frameworks and David Faure. Bugs: 350769 https