Re: Review Request 125615: Make phonon dependency optional

2015-10-18 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- (Updated Oct. 18, 2015, 8:50 a.m.) Status -- This change has been

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 13, 2015, 7:05 a.m., Albert Astals Cid wrote: > > Does this take care of removing the audio section from the config > > notifications dialog? No, it doesn't. But actually that section won't be removed either if you have no matching phonon backend installed. - Christoph

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Albert Astals Cid
> On oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 65 > > > > > > This should be part of the summary not here were people won't see it > > Christoph Cullmann wrote: > You are

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86787 --- Does this take care of removing the audio section from the

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Martin Klapetek
> On Oct. 13, 2015, 4:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin

Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- Review request for KDE Frameworks and Sune Vuorela. Repository:

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86754 --- Ship it! who wants audio notifications anyways? +1 from my

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- (Updated Oct. 12, 2015, 9:01 p.m.) Status -- This change has been

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 65 > > > > > > This should be part of the summary not here were people won't see it You are right, will fix that tomorrow. Will do

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86762 --- CMakeLists.txt (line 65)

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86771 --- As a maintainer, I would be much much more happy if it

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Sune Vuorela
> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Martin Klapetek
> On Oct. 13, 2015, 4:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. ...and I'm sure

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin