Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review89853 --- btw I would suggest using a message widget for the error

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ --- (Updated Nov. 19, 2015, 10:49 a.m.) Review request for KDE Frameworks

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Nov. 16, 2015, 12:56 p.m., Heiko Tietze wrote: > > Ship It! > > Elvis Angelaccio wrote: > I'm assuming that yours is a ship-it only from the usability side, right? Yes, UX only. No design comment from my side, but still with all of the previous considerations. - Heiko

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ --- (Updated Nov. 19, 2015, 11:04 a.m.) Status -- This change has been

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Nov. 16, 2015, 12:56 p.m., Heiko Tietze wrote: > > Ship It! I'm assuming that yours is a ship-it only from the usability side, right? - Elvis --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88553 --- Ship it! src/knewpassworddialog.h (line 183)

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88425 --- Ship it! Ship It! - Heiko Tietze On Okt. 13, 2015, 1:33

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88424 --- Ping? - Elvis Angelaccio On Oct. 13, 2015, 1:33 p.m.,

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png > > > > > > Shouldn't it have a red background when empty as well? > > Elvis Angelaccio wrote: > I'm

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review86807 --- Nice work. I would add information where the request comes

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review86806 --- File Attachment: knewpassworddialog4.png -

Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ --- Review request for KDE Frameworks, Christoph Feck and David Faure.

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png > > > > > > Shouldn't it have a red background when empty as well? I'm not sure honestly. Wouldn't be a

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png > > > > > > Shouldn't it have a red background when empty as well? > > Elvis Angelaccio wrote: > I'm