Re: Review Request 125725: Make KCrash optional for kservice

2015-10-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/#review87249 --- For the record, I would have approved this. This is really

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/#review87135 --- src/kbuildsycoca/kbuildsycoca_main.cpp (line 121)

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Christoph Cullmann
> On Oct. 20, 2015, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/ --- (Updated Oct. 20, 2015, 2 p.m.) Status -- This change has been

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Aleix Pol Gonzalez
> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread David Faure
> On Oct. 20, 2015, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Christoph Cullmann
> On Oct. 20, 2015, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Martin Gräßlin
> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Martin Gräßlin
> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Review Request 125725: Make KCrash optional for kservice

2015-10-20 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/ --- Review request for KDE Frameworks and David Faure. Summary (updated)