Re: Review Request 125830: Read protocol info from plugin metadata

> On July 15, 2016, 8:35 a.m., David Faure wrote: > > The problem with this change is that klauncher no longer recognizes freshly > > installed kioslaves. > > > > Testcase: > > $ git clone g...@github.com:shortstheory/staging-kioslave > > $ compile and install > > $ kioclient5 list stash:/ > >

Re: Review Request 125830: Read protocol info from plugin metadata

> On July 15, 2016, 8:35 a.m., David Faure wrote: > > The problem with this change is that klauncher no longer recognizes freshly > > installed kioslaves. > > > > Testcase: > > $ git clone g...@github.com:shortstheory/staging-kioslave > > $ compile and install > > $ kioclient5 list stash:/ > >

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review97430 --- The problem with this change is that klauncher no longer

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87644 --- Ship it! src/core/kprotocolinfofactory.cpp (line 79)

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/ --- (Updated Oct. 28, 2015, 7:34 a.m.) Review request for KDE Frameworks,

Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/ --- Review request for KDE Frameworks, Alex Richardson and David Faure.

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87558 --- src/core/kprotocolinfo.cpp (lines 121 - 122)

Re: Review Request 125830: Read protocol info from plugin metadata

> On Oct. 27, 2015, 10:23 p.m., Alex Merry wrote: > > src/core/kprotocolinfo.cpp, lines 121-122 > > > > > > I would still rather calculate this information - protocol is the key > > from the iterated map, and

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87561 --- Looks good to me if it still works. I don't really like all