Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

> On Nov. 3, 2015, 1:40 p.m., Milian Wolff wrote: > > src/lib/jobs/kjob.h, line 644 > > > > > > move this into KJobPrivate, no? I don't think I can. I tried and I wasn't able to call the QPrivateSignal from

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/#review87922 --- Ship it! lgtm, esp. if the tests pass src/lib/jobs/kjob.h

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/#review87944 --- Ship it! Ship It! - David Faure On Nov. 2, 2015, 7:31

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/ --- (Updated Nov. 3, 2015, 10:44 p.m.) Status -- This change has been