Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

2015-11-07 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/ --- (Updated Nov. 7, 2015, 10:07 a.m.) Status -- This change has been ma

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

2015-11-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/#review88120 --- Ship it! Looks good. Please do a "make test" before pushing,

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

2015-11-06 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/ --- (Updated Nov. 6, 2015, 5:32 p.m.) Review request for KDE Frameworks and L

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

2015-11-06 Thread Milian Wolff
> On Nov. 6, 2015, 12:25 p.m., Milian Wolff wrote: > > I'd remove the code, instead of just commenting it out if it's really not > > needed. > > > > Also, minor nitpick: QList is pretty much equivalent to QVector, > > you won't see any big difference, performance or memory wise. That said, >

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

2015-11-06 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/#review88094 --- Ship it! I'd remove the code, instead of just commenting it o

Review Request 125971: k7zip: fix memleaks, lower memory usage

2015-11-05 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/ --- Review request for KDE Frameworks and Laurent Montel. Repository: karchiv