Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 3:15 p.m.) Status -- This change has been mar

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88197 --- Ship it! Not sure if we can use the Package::JobError::Foo sy

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88195 --- Ship it! Nice. Few issues with the wording in the comments, b

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 2:51 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 2:40 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 1:18 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

> On Nov. 7, 2015, 2:03 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread_p.h, line 58 > > > > > > As you note yourself, perhaps just make it an enum? It's not private > > API, OK, but the c

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88138 --- In general, I like the idea. We have to be a bit careful to ke

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 6, 2015, 5:57 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88104 --- src/kpackage/private/packagejobthread.cpp (line 320)

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 6, 2015, 4:10 p.m.) Review request for KDE Frameworks, Plas

Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- Review request for KDE Frameworks, Plasma and Kai Uwe Broulik. Repository