Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 29, 2015, 9:34 a.m.) Status -- This change has been

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 28, 2015, 9:37 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90260 --- Ship it! OK, just one line break in the docs, then it can go

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90139 --- Sorry for the delay; Christmas happened :-) Just two more

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89671 --- tests/CMakeLists.txt (line 43)

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 17, 2015, 11:15 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89621 --- I just want to say thanks for keeping at this - I feel kinda

Re: Review Request 126185: Make the KAppTemplate CMake module global

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89618 --- kde-modules/KDEPackageAppTemplates.cmake (line 10)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 16, 2015, 12:25 p.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89562 --- kde-modules/KDETemplateGenerator.cmake (line 41)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 84 > > > > > > Use ``KDE_INSTALL_KTEMPLATESDIR`` instead of > > ``KTEMPLATES_INSTALL_DIR``. You also need to

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 14 > > > > > > OK, what needs to be in the subdirectory? are template1, template2 etc > > the subdriectory names?

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 15, 2015, 10:38 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. I'm not sure what the test should do... perhaps

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89388 --- We're getting there :-). kde-modules/KDEInstallDirs.cmake

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > > > > > Honestly, I'd just use ARG as the prefix - you're in a function, it's > > not going to leak

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89391 --- Ooh, also, please write a unit test. I can help with that if

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 9, 2015, 11:27 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 9, 2015, 12:12 p.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 9, 2015, 12:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > > > > > Naming them .zip on windows, won't make it a zip file, if you use tar > > j. I suggest

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89275 --- kde-modules/KDETemplateGenerator.cmake (line 59)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > > > > > Naming them .zip on windows, won't make it a zip file, if you use tar > > j. I suggest just

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89242 --- kde-modules/KDETemplateMacro.cmake (line 1)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > > > > > You might want to add documentation. > > > > You can get inspired with > >

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89097 --- kde-modules/KDETemplateMacro.cmake (line 1)

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Nov. 30, 2015, 1:47 p.m.) Status -- This change has been

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Nov. 27, 2015, 5:21 p.m., Simon Wächter wrote: > > Thanks for moving the template macro to the ECM module. A few things I am > > not quite sure: > > > > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop > > project > > - If you commit the patch, I'll delete the macro

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Nov. 27, 2015, 5:21 p.m., Simon Wächter wrote: > > Thanks for moving the template macro to the ECM module. A few things I am > > not quite sure: > > > > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop > > project > > - If you commit the patch, I'll delete the macro

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Nov. 27, 2015, 6:21 p.m., Simon Wächter wrote: > > Thanks for moving the template macro to the ECM module. A few things I am > > not quite sure: > > > > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop > > project > > - If you commit the patch, I'll delete the macro

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Nov. 27, 2015, 3:55 p.m.) Review request for KDE Frameworks,

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review88898 --- Ship it! Thanks for moving the template macro to the ECM

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review88896 --- `end*()` shouldn't have anything in the parenthesis.

Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.