Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89717 --- Ship it! Ship It! - Martin Gräßlin On Dec. 18, 2015, 3:20

Re: Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89713 --- i'm wondering whether those are still needed - Kai Uwe

Re: Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Aleix Pol Gonzalez
> On Dec. 18, 2015, 3:35 p.m., Kai Uwe Broulik wrote: > > i'm wondering whether those are still needed Well, it's still being called. +1 on the patch, it can be further fixed later. - Aleix --- This is an automatically generated

Re: Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/ --- (Updated Dec. 18, 2015, 11:29 p.m.) Status -- This change has been