---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126453/
---
(Updated Jan. 1, 2016, 11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126453/#review90402
---
Ship it!
Hmm, OK. It's really not obvious that order matters
> On Dec. 21, 2015, 5:33 p.m., Hrvoje Senjan wrote:
> > A public header here (DownloadWidget) includes QWidget
>
> Kevin Funk wrote:
> Qt5::Widgets is still in PUBLIC scope
Oops, i could swear i've seen it moved into PRIVATE section. Ignore.
- Hrvoje
> On Dec. 21, 2015, 4:33 p.m., Hrvoje Senjan wrote:
> > A public header here (DownloadWidget) includes QWidget
Qt5::Widgets is still in PUBLIC scope
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126453/#review89837
---
A public header here (DownloadWidget) includes QWidget
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126453/
---
Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting.