Re: Review Request 126453: Fix library order

2016-01-01 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/ --- (Updated Jan. 1, 2016, 11 p.m.) Status -- This change has been

Re: Review Request 126453: Fix library order

2016-01-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/#review90402 --- Ship it! Hmm, OK. It's really not obvious that order matters

Re: Review Request 126453: Fix library order

2015-12-21 Thread Hrvoje Senjan
> On Dec. 21, 2015, 5:33 p.m., Hrvoje Senjan wrote: > > A public header here (DownloadWidget) includes QWidget > > Kevin Funk wrote: > Qt5::Widgets is still in PUBLIC scope Oops, i could swear i've seen it moved into PRIVATE section. Ignore. - Hrvoje

Re: Review Request 126453: Fix library order

2015-12-21 Thread Kevin Funk
> On Dec. 21, 2015, 4:33 p.m., Hrvoje Senjan wrote: > > A public header here (DownloadWidget) includes QWidget Qt5::Widgets is still in PUBLIC scope - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126453: Fix library order

2015-12-21 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/#review89837 --- A public header here (DownloadWidget) includes QWidget -

Review Request 126453: Fix library order

2015-12-21 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/ --- Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting.