Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2016-01-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/ --- (Updated Jan. 2, 2016, 10:32 p.m.) Status -- This change has been

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2016-01-01 Thread David Faure
> On Jan. 1, 2016, 5:15 p.m., David Faure wrote: > > src/urifilters/shorturi/kshorturifilter.cpp, line 58 > > > > > > "despite" sounds like the api docs say that it's not thread safe. > > AFAICS the docs don't

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2016-01-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review90403 --- Ship it! src/urifilters/shorturi/kshorturifilter.cpp (line

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/ --- (Updated Dec. 28, 2015, 2:20 p.m.) Review request for KDE Frameworks.

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-28 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review90216 --- I'd say 'Ship it' on this, or wait for D. Faure. (iirc, he is

Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-22 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review89939 --- The patch seems straight-forward. I can not find the

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-22 Thread Ivan Čukić
> On Dec. 22, 2015, 4:59 p.m., Ivan Čukić wrote: > > The patch seems straight-forward. > > > > I can not find the reference that QRegularExpression is thread-safe (the > > most I see is 'all functions in this class are reentrant which is stated > > for QRegExp as well). > > > > The QRegExp