Re: Review Request 126587: Add option to build with gcov support

2016-01-04 Thread Dāvis Mosāns
> On Jan. 2, 2016, 3:57 a.m., Aleix Pol Gonzalez wrote: > > Well, then it's implemented by `ECMCoverageOption.cmake` in ECM, and > > included by `KDECompilerSettings.cmake`. If anything, the proper fix would > > be to remove this kind of code from elsewhere. Indeed. - Dāvis

Re: Review Request 126587: Add option to build with gcov support

2016-01-04 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/ --- (Updated Jan. 4, 2016, 10:21 p.m.) Status -- This change has been

Re: Review Request 126587: Add option to build with gcov support

2016-01-03 Thread Martin Gräßlin
> On Jan. 2, 2016, 12:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? > > Dāvis Mosāns wrote: > I don't know... I based this on KWin > https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249 the check in KWin predates the one in ecm and as Aleix says:

Re: Review Request 126587: Add option to build with gcov support

2016-01-01 Thread Dāvis Mosāns
> On Jan. 2, 2016, 1:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? I don't know... I based this on KWin https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249 - Dāvis --- This is an

Re: Review Request 126587: Add option to build with gcov support

2016-01-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90426 --- Well, then it's implemented by `ECMCoverageOption.cmake` in

Re: Review Request 126587: Add option to build with gcov support

2016-01-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- That's provided by ecm, isn't it? - Aleix Pol Gonzalez On

Review Request 126587: Add option to build with gcov support

2015-12-31 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/ --- Review request for KDE Frameworks. Repository: kjsembed Description