Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-14 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/ --- (Updated Feb. 14, 2016, 8:21 p.m.) Status -- This change has been

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-13 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/ --- (Updated Feb. 13, 2016, 9:45 vorm.) Review request for KDE Frameworks,

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-13 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92316 --- +1 I'm happy with this change :) - Kåre Särs On Feb. 13,

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
> On Feb. 12, 2016, 12:02 vorm., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > maybe it should be `#ifdef libintl-lite` no? Also regarding Kare's comment, I will change this to add a

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Kåre Särs
> On Feb. 12, 2016, 12:02 a.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > maybe it should be `#ifdef libintl-lite` no? > > Andreas Cord-Landwehr wrote: > Also regarding Kare's

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92301 --- +1 src/kcatalog.cpp (line 175)

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/ --- (Updated Feb. 12, 2016, 3:47 nachm.) Review request for KDE Frameworks,

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
> On Feb. 12, 2016, 3:55 nachm., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > elseif? Sure? I must admit, my Windows compiler foo is not very elaborated. Actually, I thought _MSC_VER is

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Kåre Särs
> On Feb. 12, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > elseif? > > Andreas Cord-Landwehr wrote: > Sure? I must admit, my Windows compiler foo is not very

Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92271 --- Ship it! Ship It! - Chusslove Illich On Феб. 11, 2016,

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92280 --- src/kcatalog.cpp (line 179)

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92272 --- gettext is not so nice to compile on windows either. could