Re: Review Request 127271: Disable session restore for kwalletd5

2016-04-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/ --- (Updated April 6, 2016, 7:53 a.m.) Status -- This change has been ma

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93622 --- Ship it! Ship It! - David Faure On March 11, 2016, 4:26

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/ --- (Updated March 11, 2016, 4:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93398 --- Please revert to the initial patch, I should have given it a

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-10 Thread David Faure
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/ --- (Updated March 6, 2016, 7:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-06 Thread Xuetian Weng
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-05 Thread David Faure
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-05 Thread Xuetian Weng
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-05 Thread David Faure
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-05 Thread Xuetian Weng
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? This is not to disable the whole session manager thing, but just disab

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93187 --- Looks good and more portable than the qunsetenv("SESSION_

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93147 --- +1 makes sense. - Aleix Pol Gonzalez On March 3, 2016, 9:3

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93126 --- Looks good, +1 - Martin Klapetek On March 3, 2016, 9:34 p.

Review Request 127271: Disable session restore for kwalletd5

2016-03-03 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: kwalle