Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Sandro Knauß
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/ --- (Updated March 28, 2016, 3:47 p.m.) Status -- This change has been

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Sandro Knauß
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/ --- (Updated März 28, 2016, 3:21 nachm.) Review request for KDE Frameworks

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review94075 --- LGTM. Two minor issues with the documentation, then it is

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Matthew Dawson
> On March 28, 2016, 1:39 a.m., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt handles this for us internally. I > >

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Sandro Knauß
> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt handles this for us internally. I > >

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-27 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review94057 --- Much better! I don't think this should handle XDG*

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-27 Thread Sandro Knauß
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/ --- (Updated März 27, 2016, 2:22 nachm.) Review request for KDE Frameworks