Re: Review Request 127770: Increase maximum string length in KSycoca database

> On apr 28, 2016, 9:12 a.m., Milian Wolff wrote: > > src/sycoca/ksycocautils.cpp, line 29 > > > > > > as a follow-up cleanup I suggest to introduce an enum to hold this > > magic value I can do that if the

Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/#review94946 --- src/sycoca/ksycocautils.cpp (line 29)

Re: Review Request 127770: Increase maximum string length in KSycoca database

> On apr 27, 2016, 8:36 p.m., David Faure wrote: > > src/sycoca/ksycocautils.cpp, line 39 > > > > > > Variable-length arrays are invalid C++. > > > > gcc might accept it, but -pedantic won't, and other

Re: Review Request 127770: Increase maximum string length in KSycoca database

> On April 27, 2016, 8:36 p.m., David Faure wrote: > > src/sycoca/ksycocautils.cpp, line 39 > > > > > > Variable-length arrays are invalid C++. > > > > gcc might accept it, but -pedantic won't, and other

Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/ --- (Updated apr 27, 2016, 8:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/#review94914 --- Very good find, thanks! src/sycoca/ksycocautils.cpp (line

Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/ --- Review request for KDE Frameworks and David Faure. Repository: kservice