Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-30 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/ --- (Updated April 30, 2016, 1:50 a.m.) Status -- This change has been

Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/#review95037 --- Ship it! I see. That function in Qt3 was allocating

Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-29 Thread Jos van den Oever
> On apr 29, 2016, 10:56 a.m., David Faure wrote: > > This is not about trust and attacks, this is about not allocating 4 GB of > > RAM when reading a corrupted binary file. > > Jos van den Oever wrote: > That will only happen if the file or stream is 4 GB. `QDataStream > >>(QDataStream ,

Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-29 Thread Jos van den Oever
> On apr 29, 2016, 10:56 a.m., David Faure wrote: > > This is not about trust and attacks, this is about not allocating 4 GB of > > RAM when reading a corrupted binary file. That will only happen if the file or stream is 4 GB. `QDataStream >>(QDataStream , QString )` allocates while reading

Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/#review95012 --- This is not about trust and attacks, this is about not

Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-29 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/ --- Review request for KDE Frameworks, David Faure and Milian Wolff.