Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-07-09 Thread Allen Winter
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-07-09 Thread Pino Toscano
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-06-28 Thread Michael Pyne
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-06-25 Thread Pino Toscano
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-23 Thread Michael Pyne
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/#review95717 --- Please note that: * the Q_BYTE_ORDER change was reverted,

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-07 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/ --- (Updated May 8, 2016, 12:10 a.m.) Review request for KDE Frameworks.

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-05 Thread Michael Pyne
> On May 5, 2016, 9:15 p.m., Albert Astals Cid wrote: > > src/runtime/kwalletd/main.cpp, line 97 > > > > > > See REVIEW: 126681 (commit 901c27ca7cb05cca1a960747b280d40cd7707158) it > > seems this fixes things.

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/#review95214 --- -1 src/runtime/kwalletd/main.cpp (line 97)

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/#review95195 --- +1 - Aleix Pol Gonzalez On May 5, 2016, 1:03 a.m.,

Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-04 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/ --- Review request for KDE Frameworks. Repository: kwallet Description