Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-06-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/ --- (Updated June 28, 2016, 2:04 p.m.) Status -- This change has been

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-06-26 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/#review95507 --- Ship it! What i see as a potential problem is that there

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-06-25 Thread David Faure
> On May 18, 2016, 2:16 p.m., Martin Klapetek wrote: > > A better approach I think would be to have a simple checkbox, store > > that in a config and then have KNotification/NotifyByAudio simply > > do nothing if that config/value is present. > > > > Or even have

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-05-18 Thread David Faure
> On May 18, 2016, 2:16 p.m., Martin Klapetek wrote: > > A better approach I think would be to have a simple checkbox, store > > that in a config and then have KNotification/NotifyByAudio simply > > do nothing if that config/value is present. > > > > Or even have

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/#review95588 --- A better approach I think would be to have a simple

Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-05-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/ --- Review request for KDE Frameworks, David Edmundson and Olivier Goffart.