Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 10:01 p.m.) Status -- This change has been

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97767 --- Ship it! Ship It! - David Faure On July 22, 2016, 2:48

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 2:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 12:05 p.m.) Review request for KDE Frameworks

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97757 --- src/filewidgets/knewfilemenu.cpp (line 453)

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 9:45 a.m.) Review request for KDE Frameworks and

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
> On July 22, 2016, 7:22 a.m., David Faure wrote: > > src/filewidgets/knewfilemenu.cpp, line 481 > > > > > > Wait, isn't m_popupFiles the dir where we opened the popupmenu? Why the > > RemoveFilename then?

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 8:51 a.m.) Review request for KDE Frameworks and

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97746 --- src/filewidgets/knewfilemenu.cpp (line 481)

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97745 --- Looks good expect for the unrelated change

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 6:35 a.m.) Review request for KDE Frameworks and