Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review99643 --- src/declarativeimports/core/windowthumbnail.cpp (line 231)

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98834 --- Ship it! Ship It! - Martin Gräßlin On Sept. 2, 2016,

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/ --- (Updated Sept. 2, 2016, 4:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-02 Thread David Edmundson
> On Sept. 2, 2016, 8:11 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 482-493 > > > > > > what about these commented lines? I've replaced it with a call to

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98827 --- src/declarativeimports/core/windowthumbnail.cpp (lines 481

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/ --- (Updated Sept. 1, 2016, 10:50 a.m.) Review request for KDE Frameworks

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread David Edmundson
> On Aug. 26, 2016, 11:16 a.m., Martin Gräßlin wrote: > > Ship It! Not merging yet as someone (loa) on IRC reports a crash with this - I'm quite sure I know what it'll be, the runnable trying to access WindowThumbnail after it's been deleted. I think I'll have to split all the vars that I

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98684 --- Ship it! Ship It! - Martin Gräßlin On Aug. 26, 2016,

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread Martin Gräßlin
> On Aug. 26, 2016, 9:49 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686 > > > > > > we probably need to do the same for EGL, don't we? > > David Edmundson wrote:

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread David Edmundson
> On Aug. 26, 2016, 7:49 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686 > > > > > > we probably need to do the same for EGL, don't we? GLX and ELG are the same. I

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98673 --- src/declarativeimports/core/windowthumbnail.cpp (lines 680

Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/ --- Review request for KDE Frameworks and Plasma. Repository: