Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/ --- (Updated Oct. 5, 2016, 12:41 a.m.) Status -- This change has been

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/#review99788 --- Ship it! - David Edmundson On Oct. 4, 2016, 8:54 p.m.,

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/ --- (Updated Oct. 4, 2016, 8:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread Albert Astals Cid
> On Oct. 4, 2016, 8:18 a.m., David Edmundson wrote: > > Is it this? https://bugs.kde.org/show_bug.cgi?id=348414 Sadly I don't think so, i can only reproduce a crash at closing by doing what i say on Testing Done, it may fix it, but i can't prove it. I've looked at the code quite a lot and

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/#review99754 --- Is it this? https://bugs.kde.org/show_bug.cgi?id=348414

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread Anthony Fieroni
> On Oct. 4, 2016, 7:32 a.m., Anthony Fieroni wrote: > > This is not a correct place to patch it. What is your used phonon backend? > > Albert Astals Cid wrote: > I disagree with you, none of the phonon backends call finished from stop, > because finished means "i reached the end of the

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-04 Thread Albert Astals Cid
> On Oct. 4, 2016, 4:32 a.m., Anthony Fieroni wrote: > > This is not a correct place to patch it. What is your used phonon backend? I disagree with you, none of the phonon backends call finished from stop, because finished means "i reached the end of the file" while stop just means stop. >

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-03 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/#review99749 --- This is not a correct place to patch it. What is your used

Review Request 129092: Fix crashes in NotifyByAudio

2016-10-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: