Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-11-01 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Nov. 1, 2016, 9:42 a.m.) Status -- This change has been

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-29 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review100380 --- Ship it! if you want to push it already, make sure to

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 20, 2016, 7:52 a.m.) Review request for KDE Frameworks,

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 20, 2016, 7:47 a.m.) Review request for KDE Frameworks,

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Gleb Popov
> On Oct. 19, 2016, 11:07 p.m., Oswald Buddenhagen wrote: > > an update about the runtime testing would be nice ;) Here it is: https://git.reviewboard.kde.org/r/129197/ With this and that patch, the test passes on FreeBSD. - Gleb ---

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review100144 --- an update about the runtime testing would be nice ;)

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 19, 2016, 9:51 p.m.) Review request for KDE Frameworks,

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review100127 --- doesn't look fundamentally wrong ^^ src/kpty.cpp (line

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-09 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 9, 2016, 3:51 p.m.) Review request for KDE Frameworks,

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-09 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 9, 2016, 3:49 p.m.) Review request for KDE Frameworks,

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-09 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review99871 --- cmake/FindUTEMPTER.cmake (line 45)

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-08 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 8, 2016, 8:37 p.m.) Review request for KDE Frameworks,

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-08 Thread Adriaan de Groot
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review99857 --- Perhaps indent the CMake code? It is, after all, inside the

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-08 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Oct. 8, 2016, 2:41 p.m.) Review request for KDE Frameworks,