Re: Review Request 129253: Support non integer scale factors in kiconengine

2016-10-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/ --- (Updated Oct. 25, 2016, 8:55 p.m.) Status -- This change has been

Re: Review Request 129253: Support non integer scale factors in kiconengine

2016-10-24 Thread David Edmundson
> On Oct. 24, 2016, 4:49 p.m., Jarosław Staniek wrote: > > > didn't look blurry on mouseover > > > > Did you test particular theme or can we assume lines are sharp regardless > > of theme? > > > > (for the record, when I removed 24x24 icons I got blurry icons for default > > Windows style on

Re: Review Request 129253: Support non integer scale factors in kiconengine

2016-10-24 Thread Christoph Feck
> On Oct. 24, 2016, 6:49 p.m., Jarosław Staniek wrote: > > > didn't look blurry on mouseover > > > > Did you test particular theme or can we assume lines are sharp regardless > > of theme? > > > > (for the record, when I removed 24x24 icons I got blurry icons for default > > Windows style on

Re: Review Request 129253: Support non integer scale factors in kiconengine

2016-10-24 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/#review100240 --- Ship it! - Christoph Feck On Oct. 24, 2016, 5:06 p.m.,

Re: Review Request 129253: Support non integer scale factors in kiconengine

2016-10-24 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/#review100239 --- > didn't look blurry on mouseover Did you test particular

Review Request 129253: Support non integer scale factors in kiconengine

2016-10-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/ --- Review request for KDE Frameworks and Christoph Feck. Repository: