Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-12-07 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/ --- (Updated Dec. 7, 2016, 7:18 p.m.) Status -- This change has been

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-12-06 Thread Christoph Feck
> On Nov. 9, 2016, 1:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) > > Christoph Feck wrote: > Pretty sure "konsole" reviewers group includes the maintainer, but I > would actually

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-12-03 Thread Kurt Hindenburg
> On Nov. 9, 2016, 12:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) > > Christoph Feck wrote: > Pretty sure "konsole" reviewers group includes the maintainer, but I > would actually

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-30 Thread Christoph Feck
> On Nov. 9, 2016, 1:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) > > Christoph Feck wrote: > Pretty sure "konsole" reviewers group includes the maintainer, but I > would actually

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-09 Thread Christoph Feck
> On Nov. 9, 2016, 1:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) Pretty sure "konsole" reviewers group includes the maintainer, but I would actually prefer feedback from someone using

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-09 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/#review100745 --- looks good to me, but I think hindenburg should ack it

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/ --- (Updated Nov. 6, 2016, 9:40 p.m.) Review request for KDE Frameworks and

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-06 Thread Christoph Feck
> On Nov. 6, 2016, 2:35 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > src/TerminalDisplay.cpp, line 859 > > > > > > Minor nitpick: is there any reason not to unconditionally add the > > LTR_OVERRIDE_CHAR?

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-06 Thread Martin Tobias Holmedahl Sandsmark
> On Nov. 6, 2016, 1:35 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > src/TerminalDisplay.cpp, line 859 > > > > > > Minor nitpick: is there any reason not to unconditionally add the > > LTR_OVERRIDE_CHAR?

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

2016-11-06 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/#review100648 --- src/TerminalDisplay.cpp (line 859)