Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- (Updated Dec. 31, 2016, 12:13 a.m.) Status -- This change has been

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/#review101674 --- Ship it! Ship It! - Christoph Feck On Dec. 30, 2016,

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- (Updated Dec. 30, 2016, 7:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 129709: Fix checking for valid date entered

> On Dec. 30, 2016, 5:59 p.m., Christoph Feck wrote: > > src/kdatecombobox.cpp, line 58 > > > > > > Could you please add a short comment what this function does? A > > condition like > > > >

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/#review101672 --- src/kdatecombobox.cpp (line 58)

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- (Updated Dec. 28, 2016, 5:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/#review101609 --- There is autotests/kdatecomboboxtest.cpp. Does it need

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/#review101613 --- I'd say this could really do with some autotests - Albert

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- (Updated Dec. 27, 2016, 5:46 p.m.) Review request for KDE Frameworks and

Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- Review request for KDE Frameworks and John Layt. Repository: