Re: Review Request 129807: proposal: add ksvg2ico

2017-01-13 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 13, 2017, 9:21 p.m.) Review request for KDE Frameworks,

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-13 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 13, 2017, 1:22 p.m.) Review request for KDE Frameworks,

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread René J . V . Bertin
> On Jan. 12, 2017, 6:23 p.m., Christoph Feck wrote: > > Someone more experienced with legal matters should review the verbatim > > inclusion of Qt code; in particular the license header. FWIW, the Qt code included in KDEWin's png2ico is almost identical, except for the license header. I've

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/#review101968 --- Someone more experienced with legal matters should review

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 12, 2017, 6:01 p.m.) Review request for KDE Frameworks,

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 12, 2017, 5:47 p.m.) Review request for KDE Frameworks,

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread René J . V . Bertin
> On Jan. 11, 2017, 9:54 p.m., Christoph Feck wrote: > > Could you test it with an SVG file that contains text? From what I > > remember, painting text requires a QGuiApplication to access the font > > database. > > > > Additionally, I do not like the hand-made command line parsing. We have

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 12, 2017, 10:47 a.m.) Review request for KDE Frameworks,

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/#review101961 --- I'll deal with the feedback when I get back to my main dev

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/#review101945 --- Could you test it with an SVG file that contains text? From

Review Request 129807: proposal: add ksvg2ico

2017-01-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- Review request for KDE Frameworks, kdewin and Christoph Feck.