Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-17 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/ --- (Updated Jan. 17, 2017, 10:31 p.m.) Status -- This change has been

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-17 Thread Elvis Angelaccio
> On Jan. 17, 2017, 7:51 a.m., David Faure wrote: > > enums instead of bools in APIs are good. > > > > It's funny to read "I want to change the default value [] but the new > > method can't have a default value", but it actually makes sense because the > > old method is deprecated, so

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-17 Thread David Faure
> On Jan. 17, 2017, 7:51 a.m., David Faure wrote: > > enums instead of bools in APIs are good. > > > > It's funny to read "I want to change the default value [] but the new > > method can't have a default value", but it actually makes sense because the > > old method is deprecated, so

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-17 Thread Elvis Angelaccio
> On Jan. 17, 2017, 7:51 a.m., David Faure wrote: > > enums instead of bools in APIs are good. > > > > It's funny to read "I want to change the default value [] but the new > > method can't have a default value", but it actually makes sense because the > > old method is deprecated, so

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/#review102070 --- Ship it! enums instead of bools in APIs are good. It's

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/ --- (Updated Jan. 15, 2017, 8:46 p.m.) Review request for KDE Frameworks,

Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/ --- Review request for KDE Frameworks. Repository: kio Description ---