Re: changing icon sizes no longer emits signal

2020-04-30 Thread Benjamin Port
On dimanche 26 avril 2020 14:24:27 CEST David Faure wrote: > On Saturday, April 25, 2020 4:54:43 PM CEST Friedrich W. H. Kossebau wrote: > > Am Samstag, 25. April 2020, 15:10:37 CEST schrieb Martin Koller: > > > Hi, > > > > > > in liquidshell I'm using > > > > > >

Re: changing icon sizes no longer emits signal

2020-04-27 Thread Kai Uwe Broulik
(That's why confirmation prompts are pointless, one gets so used to just acknowledge them all that that I sent this mail mid-sentece :) ...so perhaps we should just change it to always emit the dbus signal manually when something changed, rather than it being nested inside exportToKDE4().

Re: changing icon sizes no longer emits signal

2020-04-27 Thread Kai Uwe Broulik
Hi, A patch like the one attached seems to help, but someone who knows the KCM better (or has time to dig) should make this conditional on the user actually changing icon sizes, and only emit for the groups that have changed. Patch makes sense, though I wonder why we do both emitChange and a

Re: changing icon sizes no longer emits signal

2020-04-26 Thread David Faure
On Saturday, April 25, 2020 4:54:43 PM CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 25. April 2020, 15:10:37 CEST schrieb Martin Koller: > > Hi, > > > > in liquidshell I'm using > > > > connect(KIconLoader::global(), ::iconLoaderSettingsChanged, > > > > this, ::adjustIconSize); > > > >

Re: changing icon sizes no longer emits signal

2020-04-25 Thread Friedrich W. H. Kossebau
Am Samstag, 25. April 2020, 15:10:37 CEST schrieb Martin Koller: > Hi, > > in liquidshell I'm using > > connect(KIconLoader::global(), ::iconLoaderSettingsChanged, > this, ::adjustIconSize); > > to be informed whenever the icon sizes get changed in systemsettings. > I don't know since when

changing icon sizes no longer emits signal

2020-04-25 Thread Martin Koller
Hi, in liquidshell I'm using connect(KIconLoader::global(), ::iconLoaderSettingsChanged, this, ::adjustIconSize); to be informed whenever the icon sizes get changed in systemsettings. I don't know since when but at least in version Operating System: openSUSE Tumbleweed 20200419 KDE Plasma