Jenkins build became unstable: kdelibs_stable #625

2013-06-05 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/625/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110835: Port time_t to QDateTime in HostInfo (KIO)

2013-06-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110835/ --- Review request for KDE Frameworks. Description --- Port time_t to

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review33781 --- staging/kiconthemes/src/kiconloader.h

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/ --- (Updated June 5, 2013, 10:42 a.m.) Review request for KDE Frameworks and

Re: Review Request 110825: Move KEditListWidget to KWidgetAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110825/ --- (Updated June 5, 2013, 11:02 a.m.) Status -- This change has been

Re: Review Request 110825: Move KEditListWidget to KWidgetAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110825/#review33791 --- This review has been submitted with commit

Build failed in Jenkins: kdelibs_frameworks_qt5 #657

2013-06-05 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/657/changes Changes: [aleixpol] Move KEditListWidget to KWidgetAddons -- [...truncated 3657 lines...] [ 26%] Building CXX object

Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110836/ --- Review request for KDE Frameworks. Description --- Port time_t to

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/ --- (Updated June 5, 2013, 11:21 a.m.) Review request for KDE Frameworks and

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33795 --- ping! - Aleix Pol Gonzalez On June 3, 2013, 4:08 p.m.,

Re: Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110826/#review33797 --- This review has been submitted with commit

Re: Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110826/ --- (Updated June 5, 2013, noon) Status -- This change has been marked

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/ --- (Updated June 5, 2013, 2:12 p.m.) Review request for KDE Frameworks.

Build failed in Jenkins: plasma-framework_master_qt5 #469

2013-06-05 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/469/changes Changes: [aseigo] missing const -- [...truncated 551 lines...] [ 26%] Building CXX object src/plasma/CMakeFiles/plasma.dir/runnersyntax.cpp.o [ 27%] Building CXX object

Re: Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/#review33808 --- Ship it! - David Faure On June 5, 2013, 11:42 a.m.,

Re: Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/ --- (Updated June 5, 2013, 2:48 p.m.) Status -- This change has been

Re: Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/#review33809 --- This review has been submitted with commit

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110820/#review33813 --- Ship it! - David Faure On June 5, 2013, 1:21 p.m., Aleix

Jenkins build is back to normal : kdelibs_frameworks_qt5 #662

2013-06-05 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/662/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Moving KLinkDialog

2013-06-05 Thread David Faure
On Wednesday 05 June 2013 16:23:23 Aleix Pol wrote: At the moment KLinkDialog is set to be moved to KWidgetsAddons. I don't think this is correct because the class is not being exported as of KDE4, it's an internal class only used by KRichTextEdit. I'd suggest to move it to KTextWidgets and

Review Request 110842: Add reviewboardrc file

2013-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/ --- Review request for KDE Frameworks. Description --- Add reviewboardrc

Re: Review Request 110842: Add reviewboardrc file

2013-06-05 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/#review33822 --- Ship it! Yes please. - Ian Monroe On June 5, 2013, 8:32

Re: Review Request 110840: Move KFontComboBox to KDE4Support

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110840/#review33833 --- staging/kde4support/src/kdeui/fonthelpers.cpp

Re: Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110836/#review33834 --- kio/kio/slavebase.cpp

Re: Moving KLinkDialog

2013-06-05 Thread Aleix Pol
On Wed, Jun 5, 2013 at 6:34 PM, David Faure fa...@kde.org wrote: On Wednesday 05 June 2013 16:23:23 Aleix Pol wrote: At the moment KLinkDialog is set to be moved to KWidgetsAddons. I don't think this is correct because the class is not being exported as of KDE4, it's an internal class only

Re: Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Faure
On June 5, 2013, 10:35 p.m., David Gil Oliva wrote: kio/kio/slavebase.cpp, line 275 http://git.reviewboard.kde.org/r/110836/diff/1/?file=148651#file148651line275 AFAIK, time_t can be either a given moment in time (say 2013-06-06, 00:00) or an elapsed time (say 136 seconds).

Re: Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/#review33838 --- Ship it! Would be a good opportunity to fix some of the

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 5, 2013, 11:12 p.m.) Review request for KDE Frameworks.

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33839 --- Ship it! Small is good :) Just minor things left, probably

Re: Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/#review33840 --- This review has been submitted with commit

Re: Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/ --- (Updated June 5, 2013, 11:50 p.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #667

2013-06-05 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/667/changes Changes: [aleixpol] Moved KColorCombo to KWidgetsAddons -- [...truncated 3640 lines...] [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/internetgateway.cpp.o [

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 5, 2013, 11:58 p.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #669

2013-06-05 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/669/changes Changes: [aleixpol] remove wrongly included file -- [...truncated 14720 lines...] -- Installing:

Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/ --- Review request for KDE Frameworks. Description --- Besides the move,

Re: Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/#review33844 --- Missing files - David Edmundson On June 6, 2013, 12:37

Re: Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/ --- (Updated June 6, 2013, 1:03 a.m.) Review request for KDE Frameworks.