Re: Revising changing configurations with KConfig
Hi, 2013/8/1 Kevin Ottens: On Thursday 01 August 2013 00:57:05 Aleix Pol wrote: Well, that setting is used in KDirSortFilterProxyModel as well... Should we just always sort naturally by default there then? Would make sense to add an accessor pair to KDirSortFilterProxyModel, and have the default to be true for that property. Then it's up to the client code to disable it if it wants to. Yes it makes some formerly automatic behavior manual, but at the same time both that property and KDirSortFilterProxyModel aren't used that much. Well, KDirSortFilterProxyModel is being used indirectly by every application which has a File Open/Save dialog, and by apps like Kate which use a KDirOperator to display the contents of a directory somewhere else. I would not mind if every application had its own setting for natural sorting, but I'm not sure if the users who prefer non-natural sorting (yes, they do exist) would like it if they have to change the setting in every application. However, I admit that the current KDE 4 solution (change the setting in Dolphin, and then every application will use it) is not perfect either. Cheers, Frank ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Revising changing configurations with KConfig
Hello, On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: Well, KDirSortFilterProxyModel is being used indirectly by every application which has a File Open/Save dialog, and by apps like Kate which use a KDirOperator to display the contents of a directory somewhere else. Hm... Which reminds me KDirSortFilterProxyModel is in kfile... So in fact it can read the setting as it currently does. Just not through KGlobalSettings but by using KConfig directly. We'd only loose the change notification but I think we can leave with that for the time being and restore it once we have a proper solution for 5.1. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #531
See http://build.kde.org/job/plasma-framework_master_qt5/531/changes Changes: [sebas] Fix qDebug/kDebug port -- [...truncated 522 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:984:36: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1001:42: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1018:39: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1018:39: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1027:39: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1027:39: warning: ‘List’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1041:66: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1050:73: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1113:67: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1113:67: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1138:1: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h: In static member function ‘static int QMetaTypeIdKUrl::qt_metatype_id()’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1138:1: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1138:1: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h: At global scope: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1139:1: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h: In static member function ‘static int QMetaTypeIdKUrl::List::qt_metatype_id()’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1139:1: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1139:1: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140) [-Wdeprecated-declarations] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp: In function ‘int main(int, char**)’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:26:1: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:26:1: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:26:1: warning: ‘void KGlobal::ref()’ is deprecated
Re: Ki18n mostly ready
[: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc file) whether to generate tr or i18n calls. So another option to specify the translation domain would be added. I'm just wondering about the TRANSLATION_DOMAIN define vs the use of setApplicationDomain. When is one more suited than the other from the frameworks point of view? Since frameworks are typically libraries, then the define-way is the proper one. It can also be used always, regardless of what type of code it is. But if there are actually some programs with i18n calls, in them setApplicationDomain can be used. Also having this #define before including klocalizedstring.h looks like a weird API to me. Yes, but there was no better suggestion so far :) (and not only in KDE). Under the requirement that it is statically resolved which i18n call draws translations from which translation domain. The only alternative (suggested by Oswald) would be to do something on the level of CMake, such that setting the translation domain is nowhere visible in the code. But I thought this is an overkill (e.g. compared to kunitconversion example in the diff), and anyway someone can always orthogonally provide it if desired. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #532
See http://build.kde.org/job/plasma-framework_master_qt5/532/changes Changes: [sebas] Fix fallout from qDebug - kDebug porting -- [...truncated 804 lines...] Building CXX object src/declarativeimports/locale/CMakeFiles/localebindingsplugin.dir/calendarsystem.cpp.o In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kpluginfactory.h:31:0, from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kservice.h:27, from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kplugininfo.h:29, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/dataengine.h:27, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/datacontainer.h:29, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/datacontainer.cpp:19: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kexportplugin.h:71:129: note: #pragma message: K_EXPORT_PLUGIN is defined as a hack here, for compat. Port to new plugin system (QT_PLUGIN_METADATA) instead. Scanning dependencies of target kded_platformstatus [ 35%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/platformstatus.cpp.o [ 36%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/platformstatusadaptor.cpp.o In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KGlobal:1:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/calendarsystem.cpp:25: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kglobal.h: In function ‘T KGlobal::findDirectChild(const QObject*)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kglobal.h:544:31: warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const QMetaObject)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kglobal.h:534) [-Wdeprecated-declarations] [ 37%] [ 37%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o Building CXX object src/plasma/CMakeFiles/plasma.dir/dataengine.cpp.o In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KDebug:1:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/platformstatus/platformstatus.cpp:7: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h: In function ‘QString kBacktrace(int)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:107:51: warning: ‘QString kRealBacktrace(int)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:94) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:107:72: warning: ‘QString kRealBacktrace(int)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:94) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h: In function ‘QDebug kDebug(int)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:152:10: warning: ‘QDebug kDebugStream(QtMsgType, int, const char*, int, const char*)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:81) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:152:39: warning: ‘QDebug kDebugStream(QtMsgType, int, const char*, int, const char*)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:81) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h: In function ‘QDebug kDebug(bool, int)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:154:32: warning: ‘QDebug kDebugDevNull()’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:88) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:154:46: warning: ‘QDebug kDebugDevNull()’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h:88) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kdebug.h: In function ‘QDebug kWarning(int)’:
Jenkins build is back to stable : plasma-framework_master_qt5 #534
See http://build.kde.org/job/plasma-framework_master_qt5/534/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111833/ --- Review request for KDE Frameworks. Summary (updated) - Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel Description (updated) --- Directly read the config instead of using KGlobalSettings as a proxy for the setting. We lose the setting changed functionality but now we don't depend on KGlobalSettings class. There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed. Diffs - Diff: http://git.reviewboard.kde.org/r/111833/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Ki18n mostly ready
Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: [: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc file) whether to generate tr or i18n calls. So another option to specify the translation domain would be added. OK, sounds good. We should make tr the default if that's not already the case though. Also having this #define before including klocalizedstring.h looks like a weird API to me. Yes, but there was no better suggestion so far :) (and not only in KDE). Under the requirement that it is statically resolved which i18n call draws translations from which translation domain. The only alternative (suggested by Oswald) would be to do something on the level of CMake, such that setting the translation domain is nowhere visible in the code. But I thought this is an overkill (e.g. compared to kunitconversion example in the diff), and anyway someone can always orthogonally provide it if desired. Might be better indeed. Could easily be wrapped in a cmake macro I guess. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111833/ --- (Updated Aug. 1, 2013, 11:03 a.m.) Review request for KDE Frameworks. Changes --- Add porting notes. Description --- Directly read the config instead of using KGlobalSettings as a proxy for the setting. We lose the setting changed functionality but now we don't depend on KGlobalSettings class. There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed. Diffs (updated) - KDE5PORTING.html 9d84525 kfile/kdirsortfilterproxymodel.cpp c8ea9b2 Diff: http://git.reviewboard.kde.org/r/111833/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36906
---
Some more nitpicks from my side - sorry Sebas I hope you don't think I'm too
pedantic :) But I hope others read this as well and start following the new
best-practices for Qt5 codebases.
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27217
remove
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27218
use QCommandLineParser or whatever its called, to follow the style of the
includes below
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27216
both are not used anymore, or?
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27208
endl instead of \n and no nead for .toLocal8Bit().constData()
just:
QTextStream out(stdout)
out msg endl;
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27209
use intializer list
KConfigToJson::KConfigToJson(...)
: m_parser(parser)
{
}
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27210
that's not debug, that's an error message, or?
I really suggest you get rid of the coutput free function and instead add
these two at the top:
static QTextStream cout(stdout);
static QTextStream cerr(stderr);
Then use them wherever appropriate, e.g. here:
cerr Failed to resolve filenames m_inFile m_outFile endl;
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27211
if you use a static cout as I showed above, the QStringLiteral won't be
necessary.
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27212
share the QStringLiteral, i.e. at the top add
static const QString INPUT = QStringLiteral(input);
Then use it here and above. Do the same for output below.
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27213
QStringLiteral for both
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27214
use QStringLiteral for the values
staging/kservice/tools/desktoptojson/main.cpp
http://git.reviewboard.kde.org/r/111689/#comment27215
I'm not sure about the style guide in KDELibs, but aren't the
KLocalizedString kind of includes preferred? Same for the Qt files.
- Milian Wolff
On July 30, 2013, 7:45 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated July 30, 2013, 7:45 p.m.)
Review request for KDE Frameworks and David Faure.
Description
---
Small program which takes a .desktop file and converts it to json. This is
useful to convert plugins which have their metadata in .desktop files (i.e.
all KDE plugins) to Qt's new plugin system.
Diffs
-
staging/kservice/tools/CMakeLists.txt PRE-CREATION
staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION
staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION
staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION
staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111689/diff/
Testing
---
Converted metadata of several plugins and used them from QPluginLoader --
works.
Thanks,
Sebastian Kügler
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111834: Move KHelpClient into xmlgui
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111834/ --- Review request for KDE Frameworks. Description --- The class still was in kdeui so it had to be moved, after discussing with ervin, it seemed like it's a good place for the function to be. After all, it's just a helper function, we can always (hope to) instantiate the help using QDesktopServices::openUrl() Diffs - kdeui/CMakeLists.txt 5cbcfb0 staging/xmlgui/src/CMakeLists.txt 255960f staging/xmlgui/src/khelpclient.h e5f9946 staging/xmlgui/src/khelpclient.cpp dda0b13 Diff: http://git.reviewboard.kde.org/r/111834/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote: Some more nitpicks from my side - sorry Sebas I hope you don't think I'm too pedantic :) But I hope others read this as well and start following the new best-practices for Qt5 codebases. No problem at all, in fact I much appreciate the thorough review, as indeed this is a good way to transfer knowledge about best practises. :) On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/main.cpp, line 20 http://git.reviewboard.kde.org/r/111689/diff/2/?file=175525#file175525line20 I'm not sure about the style guide in KDELibs, but aren't the KLocalizedString kind of includes preferred? Same for the Qt files. There's no header KLocalizedString, only klocalizedstring.h exists. I'll leave that for now, as it needs addressing elsewhere first. On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 26 http://git.reviewboard.kde.org/r/111689/diff/2/?file=175524#file175524line26 use QCommandLineParser or whatever its called, to follow the style of the includes below There's no CamelCase header for QCommandLineParser. I'll leave it as-is here. - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36906 --- On July 30, 2013, 7:45 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated July 30, 2013, 7:45 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 4:32 p.m.) Review request for KDE Frameworks and David Faure. Changes --- All issues addressed, thanks Kevin and Milian for the reviews! Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs (updated) - staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36923 --- staging/kservice/tools/desktoptojson/kconfigtojson.h http://git.reviewboard.kde.org/r/111689/#comment27230 sorry for more style nitpicking: int argc, char **argv staging/kservice/tools/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment27231 int argc staging/kservice/tools/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment27233 Do we want the output/errors to be translated? staging/kservice/tools/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment27232 since the purpose of those to containers is lookup, maybe QSetQString instead? Not that it matters a lot given there are only two keys, just saying :) - Kevin Krammer On Aug. 1, 2013, 4:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 4:32 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57 Do we want the output/errors to be translated? It's really a helper tool for the build process, so no. I've removed the translations from main.cpp as well. - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36923 --- On Aug. 1, 2013, 4:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 4:32 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 5:44 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Addressed comments, thanks! Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs (updated) - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 5:49 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Also share the strings in main.cpp. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs (updated) - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 kio/tests/netaccesstest.cpp 174feb0 staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 1, 2013, 5:52 p.m.) Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 kio/tests/netaccesstest.cpp 174feb0 staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:03 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Licensing header: lgpl3+ kde e.V. as recommended in kdelibs licensing policy Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs (updated) - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57 Do we want the output/errors to be translated? Sebastian Kügler wrote: It's really a helper tool for the build process, so no. I've removed the translations from main.cpp as well. I see. I am not expert on CMake, so the questions becomes: is this the right way to ensure it does not end up in /usr/bin or something? But rather in a place where it can be found by the build system when needed? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36923 --- On Aug. 1, 2013, 6:03 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:03 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36933
---
nearly there! :)
staging/kservice/tools/desktoptojson/kconfigtojson.h
http://git.reviewboard.kde.org/r/111689/#comment27241
this is not being used here, QString include should be enough I think.
staging/kservice/tools/desktoptojson/kconfigtojson.h
http://git.reviewboard.kde.org/r/111689/#comment27244
is this the coding style of KDELibs?
class Foo
{
public:
Foo();
};
I assumed this is it:
class Foo
{
public:
Foo();
};
But the coding style does not tell which one it is. Maybe David Faure or so
should say what is preferred.
staging/kservice/tools/desktoptojson/kconfigtojson.h
http://git.reviewboard.kde.org/r/111689/#comment27242
no need for virtual, actually no need for the dtor at all.
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27243
then don't pass them along at all.
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27249
just do return convert(...);
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27247
same as below, check for the invalidity first, then return early. move the
rest out of the conditional
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27245
personally, I prefer to reduce the conditional clutter by doing things like
this:
if (...) {
var = asdf();
if (!valid(var)) {
return false;
}
do_stuff();
}
staging/kservice/tools/desktoptojson/kconfigtojson.cpp
http://git.reviewboard.kde.org/r/111689/#comment27246
merge with above to else if?
- Milian Wolff
On Aug. 1, 2013, 6:03 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 6:03 p.m.)
Review request for KDE Frameworks and David Faure.
Description
---
Small program which takes a .desktop file and converts it to json. This is
useful to convert plugins which have their metadata in .desktop files (i.e.
all KDE plugins) to Qt's new plugin system.
Diffs
-
staging/kservice/tools/CMakeLists.txt PRE-CREATION
staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION
staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION
staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION
staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111689/diff/
Testing
---
Converted metadata of several plugins and used them from QPluginLoader --
works.
Thanks,
Sebastian Kügler
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60 just do return convert(...); No, that would give the opposite return value. To have the same behavior you need return !convert(...), or return convert(...) ? 0 : 1; - Nicolás --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36933 --- On Aug. 1, 2013, 6:03 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:03 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:56 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Updated patch. Also, licensing is LGPL2.1+ as per kdelibs policy, not 3.x. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs (updated) - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:59 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Fixed indentation in header. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs (updated) - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Problem compiling
Hi, I'm having problems compiling KF5. The configuration gives me this: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5UiTools/Qt5UiToolsConfig.cmake:15 (message): The imported target Qt5::UiTools references the file /home/david/devel/kf5-development/qt5/qtbase/lib/libQt5UiTools.a but this file does not exist. Possible reasons include: * The file was deleted, renamed, or moved to another location. * An install or uninstall procedure did not complete successfully. * The installation package was faulty and contained /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5UiTools/Qt5UiToolsConfig.cmake but not all the files it references. Call Stack (most recent call first): /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5UiTools/Qt5UiToolsConfig.cmake:32 (_qt5_UiTools_check_file_exists) /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5UiTools/Qt5UiToolsConfig.cmake:121 (_populate_UiTools_target_properties) CMakeLists.txt:210 (find_package) -- Configuring incomplete, errors occurred! See also /home/david/devel/kf5-development/build/kdelibs-frameworks/CMakeFiles/CMakeOutput.log. See also /home/david/devel/kf5-development/build/kdelibs-frameworks/CMakeFiles/CMakeError.log. make: *** [cmake_check_build_system] Error 1 -- I have built Qt5 with clang, since the building with gcc gives me errors (Except that, I have followed the instructions in the KF5 wiki). Any hint? Thank you in advance David Gil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Revising changing configurations with KConfig
El Dijous, 1 d'agost de 2013, a les 08:28:13, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: Well, KDirSortFilterProxyModel is being used indirectly by every application which has a File Open/Save dialog, and by apps like Kate which use a KDirOperator to display the contents of a directory somewhere else. Hm... Which reminds me KDirSortFilterProxyModel is in kfile... So in fact it can read the setting as it currently does. Just not through KGlobalSettings but by using KConfig directly. We'd only loose the change notification but I think we can leave with that for the time being and restore it once we have a proper solution for 5.1. And what is that proper solution? Cheers, Albert Regards. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Ki18n mostly ready
El Dijous, 1 d'agost de 2013, a les 12:54:07, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: [: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc file) whether to generate tr or i18n calls. So another option to specify the translation domain would be added. OK, sounds good. We should make tr the default if that's not already the case though. Disagree. ki18n is our i18n framework. If something else that depends on kconfig_compiler wants to use the poor man's solution, it's up to them, but i don't see why we should force it by default to everyone. Cheers, Albert Also having this #define before including klocalizedstring.h looks like a weird API to me. Yes, but there was no better suggestion so far :) (and not only in KDE). Under the requirement that it is statically resolved which i18n call draws translations from which translation domain. The only alternative (suggested by Oswald) would be to do something on the level of CMake, such that setting the translation domain is nowhere visible in the code. But I thought this is an overkill (e.g. compared to kunitconversion example in the diff), and anyway someone can always orthogonally provide it if desired. Might be better indeed. Could easily be wrapped in a cmake macro I guess. Regards. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60 just do return convert(...); Nicolás Alvarez wrote: No, that would give the opposite return value. To have the same behavior you need return !convert(...), or return convert(...) ? 0 : 1; Thanks :) - Milian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36933 --- On Aug. 1, 2013, 6:59 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:59 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36947 --- Ship it! awesome, I like it now :) - Milian Wolff On Aug. 1, 2013, 6:59 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:59 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/tools/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Revising changing configurations with KConfig
On Thursday 01 August 2013 22:02:15 Albert Astals Cid wrote: El Dijous, 1 d'agost de 2013, a les 08:28:13, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: Well, KDirSortFilterProxyModel is being used indirectly by every application which has a File Open/Save dialog, and by apps like Kate which use a KDirOperator to display the contents of a directory somewhere else. Hm... Which reminds me KDirSortFilterProxyModel is in kfile... So in fact it can read the setting as it currently does. Just not through KGlobalSettings but by using KConfig directly. We'd only loose the change notification but I think we can leave with that for the time being and restore it once we have a proper solution for 5.1. And what is that proper solution? What Aleix was proposing in the first email of that thread: extending the .kcfg syntax and generating the code for broadcasting setting changes. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Ki18n mostly ready
On Thursday 01 August 2013 22:03:36 Albert Astals Cid wrote: El Dijous, 1 d'agost de 2013, a les 12:54:07, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: [: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc file) whether to generate tr or i18n calls. So another option to specify the translation domain would be added. OK, sounds good. We should make tr the default if that's not already the case though. Disagree. ki18n is our i18n framework. If something else that depends on kconfig_compiler wants to use the poor man's solution, it's up to them, but i don't see why we should force it by default to everyone. Well, the default has to make sense to someone who just makes a Qt application and use KConfig as an extra. If kconfig_compiler generates by default something which doesn't build for them we're doing something wrong. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
