Re: Review Request 112556: Move itemviews to tier2
On Tuesday 10 September 2013 21:46:45 Christoph Feck wrote: So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it too late for that? I'd be fine with that. There are indeed other item models and item views than the ones provided by KF5, so a k makes sense. Stephen, what do you think? Do we plan to have a proper/final let's look at what we did API review after everything has settled? That would be good indeed, but let's do it along the way as well rather than postpone it all :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112660: KPluginInfo rework for KPluginTrader
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39935 --- Ship it! ... after fixing the last two small issues. staging/kservice/src/services/kplugininfo.h http://git.reviewboard.kde.org/r/112660/#comment29479 missing docu for libraryPath staging/kservice/src/services/kplugininfo.h http://git.reviewboard.kde.org/r/112660/#comment29480 can be removed now, no? - David Faure On Sept. 12, 2013, 7:07 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 12, 2013, 7:07 p.m.) Review request for KDE Frameworks and David Faure. Description --- This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted in a separate patch). It basically makes KPluginInfo's API a little bit more like KService by adding a property(QString) accessor to the plugin info. This allows us on the one hand Part of this patch, and much of its churn, is the internal change from independent QStrings and QStringLists to a QVariantMap. This is how the metadata comes in from KPlugin*, and it allows us to make properties accessible by name. There's also a fair bit of moving from QLatin1String to QStringLiteral in there, most of these lines needed changes anyway. Additionally, the keys of properties are now shared in the d-pointer. This change is source compatible to the old version. Diffs - staging/kservice/src/services/kplugininfo.h c2e5bab staging/kservice/src/services/kplugininfo.cpp 21e0882 Diff: http://git.reviewboard.kde.org/r/112660/diff/ Testing --- All tests still pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39936 --- See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt. This is preparation for future splitting. The variables are necessary for that, for now, as I understand it. Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :) - David Faure On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 12, 2013, 5 p.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Dependency specifications
On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls. And I disagree. If you build the framework with unittests disabled (like distros will probably do) then there's no point in searching for QtTest. Modularity wins again, better do that inside the autotests subdir. Apart from QtTest, I agree, though. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39940 --- Ship it! Much simpler indeed - David Faure On Sept. 12, 2013, 1:30 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/ --- (Updated Sept. 12, 2013, 1:30 p.m.) Review request for KDE Frameworks, David Faure and Aurélien Gâteau. Description --- updateUserTimestamp() used to fetch the current time by creating a property notify event and wait till it is received by inspecting the XEvent queue. That doesn't work with XCB anymore, but Qt provides this functionality for us, so just use that. At the same time the argument is changed from int to unsigned long as that's what the method in QX11Info returns. Diffs - staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f Diff: http://git.reviewboard.kde.org/r/112684/diff/ Testing --- compiles. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112689: Drop KI18n dependencies in KCompletion
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39942 --- staging/kcompletion/src/klineedit.cpp http://git.reviewboard.kde.org/r/112689/#comment29488 QObject::tr ( const char * sourceText, const char * disambiguation = 0 ) - you need to swap the arguments around. - David Faure On Sept. 12, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 12, 2013, 2:47 p.m.) Review request for KDE Frameworks. Description --- It's not really adding much value here, so I'd say we can drop it. I'm not sure that tr() is as well the correct replacement for i18nc(), can anybody confirm? Diffs - staging/kcompletion/src/CMakeLists.txt dd9d99c staging/kcompletion/src/kcombobox.cpp 8a73a1b staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 staging/kcompletion/src/klineedit.cpp 76ef377 Diff: http://git.reviewboard.kde.org/r/112689/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112681: Tests for KPluginTrader and friends
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review39943 --- staging/kservice/autotests/pluginlocatortest.cpp http://git.reviewboard.kde.org/r/112681/#comment29489 this line does nothing staging/kservice/autotests/pluginlocatortest.cpp http://git.reviewboard.kde.org/r/112681/#comment29492 needs to be updated for the new argument order! staging/kservice/autotests/pluginlocatortest.cpp http://git.reviewboard.kde.org/r/112681/#comment29490 why not QCOMPARE(res.count(), 1), more precisely? staging/kservice/autotests/pluginlocatortest.cpp http://git.reviewboard.kde.org/r/112681/#comment29491 const QString constraint = ... staging/kservice/autotests/pluginlocatortest.cpp http://git.reviewboard.kde.org/r/112681/#comment29494 this should be data-driven. The code is almost the same in all these findPlugin*() tests, only the input data (e.g. the constraint) and the expected result (0 or 1) changes - create a _data() method with 3 columns (servicetype, constraint, expectedResultCount) staging/kservice/autotests/pluginlocatortest.cpp http://git.reviewboard.kde.org/r/112681/#comment29493 use QCOMPARE() staging/kservice/tests/pluginlocator/CMakeLists.txt http://git.reviewboard.kde.org/r/112681/#comment29498 Add a comment (on the same line) about why it's needed staging/kservice/tests/pluginlocator/main.cpp http://git.reviewboard.kde.org/r/112681/#comment29495 On the stack, and after the app. staging/kservice/tests/pluginlocator/main.cpp http://git.reviewboard.kde.org/r/112681/#comment29496 addHelpOption() is missing staging/kservice/tests/pluginlocator/plugintest.h http://git.reviewboard.kde.org/r/112681/#comment29497 Deriving from Q*Application is bad practice in apps (very unflexible, leads to all-in-one-class code). And there's no need to do that (you're not reimplementing any virtual methods). OK it doesn't matter that much in a test, but I still don't like seeing it, it inspires other people to do it wrong. This could be a simple QObject. - David Faure On Sept. 12, 2013, 3:35 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 12, 2013, 3:35 a.m.) Review request for KDE Frameworks and David Faure. Description --- Tests for KPluginTrader. Under autotests/, there's a new test class which runs a variety of queries using KPluginTrader. There's also a small plugin, which is used to verify correct metadata querying and loading. It's not installed since QPluginLoader conveniently contains the working directory when looking for plugins - it's found just fine. Under tests/, there's a test which will query for a variety of other plugins. This one is more geared towards performance testing. When run from make test, it will pass anyway. Code can also be found in kdelibs[sebas/pluginlocator]. Diffs - staging/kservice/autotests/CMakeLists.txt d341040 staging/kservice/autotests/fakeplugin.desktop PRE-CREATION staging/kservice/autotests/fakeplugin.json PRE-CREATION staging/kservice/autotests/nsaplugin.h PRE-CREATION staging/kservice/autotests/nsaplugin.cpp PRE-CREATION staging/kservice/autotests/pluginlocatortest.h PRE-CREATION staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION staging/kservice/tests/CMakeLists.txt 3793aea staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112681/diff/ Testing --- make test =) All tests pass on top of my patches. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Templates for frameworks CMake files
Hi,
I have been playing around with itemviews CMake files and put together some
templates for the top level CMakeLists.txt and *Config.cmake.in. You can find
them attached there. Any one against me adding those to the repository?
Auréliencmake_minimum_required(VERSION 2.8.11)
project(FooBar)
find_package(ECM 0.0.8 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
set(REQUIRED_QT_VERSION 5.2.0)
# Required Qt5 components to build this framework
# For example:
# find_package(Qt5 ${REQUIRED_QT_VERSION} REQUIRED NO_MODULE COMPONENTS Widgets)
if(NOT kdelibs_SOURCE_DIR)
find_package(KF5 5.0.0 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs)
# Required KF5 frameworks to build this framework
# For example:
# find_package(KCoreAddons 5.0.0 REQUIRED)
endif()
include(FeatureSummary)
include(ECMSetupVersion)
ecm_setup_version(5 0 0 VARIABLE_PREFIX FOOBAR
VERSION_HEADER ${CMAKE_CURRENT_BINARY_DIR}/foobar_version.h
PACKAGE_VERSION_FILE ${CMAKE_CURRENT_BINARY_DIR}/FooBarConfigVersion.cmake)
add_subdirectory(src)
add_subdirectory(autotests)
add_subdirectory(tests)
# create a Config.cmake and a ConfigVersion.cmake file and install them
set(CMAKECONFIG_INSTALL_DIR ${CMAKECONFIG_INSTALL_PREFIX}/FooBar)
include(CMakePackageConfigHelpers)
configure_package_config_file(
${CMAKE_CURRENT_SOURCE_DIR}/FooBarConfig.cmake.in
${CMAKE_CURRENT_BINARY_DIR}/FooBarConfig.cmake
INSTALL_DESTINATION ${CMAKECONFIG_INSTALL_DIR}
PATH_VARS INCLUDE_INSTALL_DIR CMAKE_INSTALL_PREFIX
)
install(FILES
${CMAKE_CURRENT_BINARY_DIR}/FooBarConfig.cmake
${CMAKE_CURRENT_BINARY_DIR}/FooBarConfigVersion.cmake
DESTINATION ${CMAKECONFIG_INSTALL_DIR}
COMPONENT Devel
)
install(EXPORT FooBarTargets DESTINATION ${CMAKECONFIG_INSTALL_DIR} FILE FooBarTargets.cmake NAMESPACE KF5:: )
install(FILES
${CMAKE_CURRENT_BINARY_DIR}/foobar_version.h
DESTINATION ${INCLUDE_INSTALL_DIR} COMPONENT Devel
)
if (${CMAKE_BINARY_DIR} STREQUAL ${CMAKE_CURRENT_BINARY_DIR})
feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES)
endif()
@PACKAGE_INIT@
# Required components to use this framework
# For example:
# find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)
# find_dependency(KCoreAddons ${PACKAGE_VERSION})
set(FooBar_INSTALL_PREFIX @PACKAGE_CMAKE_INSTALL_PREFIX@)
set_and_check(FooBar_INCLUDE_DIR @PACKAGE_INCLUDE_INSTALL_DIR@)
include(${CMAKE_CURRENT_LIST_DIR}/FooBarTargets.cmake)
set(FooBar_LIBRARIES KF5::FooBar)
set(FooBar_INCLUDE_DIRS ${FooBar_INCLUDE_DIR} )
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m.) Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Changes --- add neundorf Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
On Sept. 13, 2013, 7:35 a.m., David Faure wrote: See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt. This is preparation for future splitting. The variables are necessary for that, for now, as I understand it. Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :) Well, then it shouldn't matter, because it makes the modules less inter-dependent. At the moment we're relying too much about things defined in kdelibs/CMakeLists.txt and we're having things defined in weird ways, IMHO. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39936 --- On Sept. 13, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m.) Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112689: Drop KI18n dependencies in KCompletion
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 13, 2013, 11:01 a.m.) Review request for KDE Frameworks. Changes --- Properly use tr() as a replacement for i18nc() Description --- It's not really adding much value here, so I'd say we can drop it. I'm not sure that tr() is as well the correct replacement for i18nc(), can anybody confirm? Diffs (updated) - staging/kcompletion/src/CMakeLists.txt dd9d99c staging/kcompletion/src/kcombobox.cpp 8a73a1b staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 staging/kcompletion/src/klineedit.cpp 76ef377 staging/knotifications/CMakeLists.txt 2e42ab3 Diff: http://git.reviewboard.kde.org/r/112689/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Dependency specifications
On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls. And I disagree. If you build the framework with unittests disabled (like distros will probably do) then there's no point in searching for QtTest. Modularity wins again, better do that inside the autotests subdir. Apart from QtTest, I agree, though. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 Well, then let's make this a especial case for autotests/ and tests/. We shouldn't have any find_package() within src/, and that's the case in many places. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112700: Prepare KI18n to move to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 13, 2013, 11:05 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112700: Prepare KI18n to move to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39948 --- This review has been submitted with commit 9c0e739a866eefd5aa9074ab1b5729611e64d001 by Aleix Pol to branch frameworks. - Commit Hook On Sept. 12, 2013, 6 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 12, 2013, 6 p.m.) Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Dependency specifications
On Friday 13 September 2013 13:03:29 Aleix Pol wrote: On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls. And I disagree. If you build the framework with unittests disabled (like distros will probably do) then there's no point in searching for QtTest. Modularity wins again, better do that inside the autotests subdir. Apart from QtTest, I agree, though. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 Well, then let's make this a especial case for autotests/ and tests/. We shouldn't have any find_package() within src/, and that's the case in many places. Not tests/. That's for manual tests, no qtestlib there. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112699: Reorganize KDocTools cmake code
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/ --- (Updated Sept. 13, 2013, 11:15 a.m.) Review request for KDE Frameworks and Stephen Kelly. Changes --- Adds the log listing the features, in case it's built separately. Description --- Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake. Wouldn't it make sense to rename it to FindKDocTools.cmake? Diffs (updated) - staging/kdoctools/CMakeLists.txt 7687f97 staging/kdoctools/src/CMakeLists.txt 6910ef7 Diff: http://git.reviewboard.kde.org/r/112699/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112699: Reorganize KDocTools cmake code
On Sept. 12, 2013, 7:57 p.m., Stephen Kelly wrote: Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Why is this necessary to move it to its own tier? That wouldn't be an existing tier? Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake. Wouldn't it make sense to rename it to FindKDocTools.cmake? I don't think it would. Is your 'At the moment' referring to 'pre repo-split' times while we're still building everything monolithically? Thanks, I don't think it has much to do with it being in a pre-repo-split stage. I think that we have to think about how we want applications to use KDocTools eventually, as we do with our C++ code. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/#review39917 --- On Sept. 12, 2013, 5:22 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/ --- (Updated Sept. 12, 2013, 5:22 p.m.) Review request for KDE Frameworks and Stephen Kelly. Description --- Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake. Wouldn't it make sense to rename it to FindKDocTools.cmake? Diffs - staging/kdoctools/CMakeLists.txt 7687f97 staging/kdoctools/src/CMakeLists.txt 6910ef7 Diff: http://git.reviewboard.kde.org/r/112699/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Dependency specifications
On Fri, Sep 13, 2013 at 1:17 PM, David Faure fa...@kde.org wrote: On Friday 13 September 2013 13:03:29 Aleix Pol wrote: On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls. And I disagree. If you build the framework with unittests disabled (like distros will probably do) then there's no point in searching for QtTest. Modularity wins again, better do that inside the autotests subdir. Apart from QtTest, I agree, though. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 Well, then let's make this a especial case for autotests/ and tests/. We shouldn't have any find_package() within src/, and that's the case in many places. Not tests/. That's for manual tests, no qtestlib there. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 Well, but in that case you'll maybe want to find QtGui, QtWidgets or KF5::AwesomeTests. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112689: Drop KI18n dependencies in KCompletion
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39951 --- Ship it! Looks good. Remember to adjust the commit log if it still contains your question about tr()/i18nc(). - David Faure On Sept. 13, 2013, 11:01 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 13, 2013, 11:01 a.m.) Review request for KDE Frameworks. Description --- It's not really adding much value here, so I'd say we can drop it. I'm not sure that tr() is as well the correct replacement for i18nc(), can anybody confirm? Diffs - staging/kcompletion/src/CMakeLists.txt dd9d99c staging/kcompletion/src/kcombobox.cpp 8a73a1b staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 staging/kcompletion/src/klineedit.cpp 76ef377 staging/knotifications/CMakeLists.txt 2e42ab3 Diff: http://git.reviewboard.kde.org/r/112689/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112696: Moves KNotifications to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39952 --- Ship it! Ship It! - David Faure On Sept. 12, 2013, 4:25 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/ --- (Updated Sept. 12, 2013, 4:25 p.m.) Review request for KDE Frameworks. Description --- Not much else going on. Diffs - staging/CMakeLists.txt f0b6bf0 staging/knotifications/CMakeLists.txt staging/knotifications/KNotificationsConfig.cmake.in staging/knotifications/autotests/CMakeLists.txt staging/knotifications/cmake/FindDBusMenuQt5.cmake staging/knotifications/src/CMakeLists.txt staging/knotifications/src/config-knotifications.h.cmake staging/knotifications/src/knotification.h staging/knotifications/src/knotification.cpp staging/knotifications/src/knotificationmanager.cpp staging/knotifications/src/knotificationmanager_p.h staging/knotifications/src/knotificationrestrictions.h staging/knotifications/src/knotificationrestrictions.cpp staging/knotifications/src/kstatusnotifieritem.h staging/knotifications/src/kstatusnotifieritem.cpp staging/knotifications/src/kstatusnotifieritemdbus_p.h staging/knotifications/src/kstatusnotifieritemdbus_p.cpp staging/knotifications/src/kstatusnotifieritemprivate_p.h staging/knotifications/src/org.freedesktop.Notifications.xml staging/knotifications/src/org.kde.KNotify.xml staging/knotifications/src/org.kde.StatusNotifierItem.xml staging/knotifications/src/org.kde.StatusNotifierWatcher.xml staging/knotifications/tests/CMakeLists.txt staging/knotifications/tests/knotificationrestrictionstest.cpp staging/knotifications/tests/kstatusnotifieritemtest.h staging/knotifications/tests/kstatusnotifieritemtest.cpp tier2/CMakeLists.txt 62faacb Diff: http://git.reviewboard.kde.org/r/112696/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Dependency specifications
On Friday 13 September 2013 13:17:47 Aleix Pol wrote: Well, but in that case you'll maybe want to find QtGui, QtWidgets or KF5::AwesomeTests. Ah yes, true, manual tests can have more deps sometimes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112710: Move KIO::NetAccess to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- Review request for KDE Frameworks and David Faure. Description --- Move KIO::NetAccess to kde4support. I have also added @deprecated to all the functions that did not have with the exception of fish_execute that I'm unsure if we want to provide an alternative for that (since it will always be dependent on a slave...). Also, I haven't added KDE4SUPPORT_DEPREACTED_EXPORT to all methods, that would add too much noise when compiling other modules... we have to find a better solution to deprecate all kde4support. Diffs - kio/CMakeLists.txt d44dcc2 kio/kio/netaccess.h 11a4ac9 kio/kio/netaccess.cpp kio/tests/CMakeLists.txt 1874712 kio/tests/fileundomanagertest.cpp 5f5fb27 kio/tests/jobguitest.cpp ec65942 kio/tests/jobremotetest.cpp ce99ff4 kio/tests/kdirmodeltest.cpp 256d32e kio/tests/netaccesstest.cpp staging/kde4support/src/CMakeLists.txt 466c195 staging/kde4support/tests/CMakeLists.txt 2c38f46 Diff: http://git.reviewboard.kde.org/r/112710/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112710: Move KIO::NetAccess to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39953 --- Ship it! Ship It! - David Faure On Sept. 13, 2013, 11:21 a.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- (Updated Sept. 13, 2013, 11:21 a.m.) Review request for KDE Frameworks and David Faure. Description --- Move KIO::NetAccess to kde4support. I have also added @deprecated to all the functions that did not have with the exception of fish_execute that I'm unsure if we want to provide an alternative for that (since it will always be dependent on a slave...). Also, I haven't added KDE4SUPPORT_DEPREACTED_EXPORT to all methods, that would add too much noise when compiling other modules... we have to find a better solution to deprecate all kde4support. Diffs - kio/CMakeLists.txt d44dcc2 kio/kio/netaccess.h 11a4ac9 kio/kio/netaccess.cpp kio/tests/CMakeLists.txt 1874712 kio/tests/fileundomanagertest.cpp 5f5fb27 kio/tests/jobguitest.cpp ec65942 kio/tests/jobremotetest.cpp ce99ff4 kio/tests/kdirmodeltest.cpp 256d32e kio/tests/netaccesstest.cpp staging/kde4support/src/CMakeLists.txt 466c195 staging/kde4support/tests/CMakeLists.txt 2c38f46 Diff: http://git.reviewboard.kde.org/r/112710/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112696: Moves KNotifications to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39954 --- This review has been submitted with commit 3359a8cbe993159d830bc0610097edabc2408a9a by Aleix Pol to branch frameworks. - Commit Hook On Sept. 12, 2013, 4:25 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/ --- (Updated Sept. 12, 2013, 4:25 p.m.) Review request for KDE Frameworks. Description --- Not much else going on. Diffs - staging/CMakeLists.txt f0b6bf0 staging/knotifications/CMakeLists.txt staging/knotifications/KNotificationsConfig.cmake.in staging/knotifications/autotests/CMakeLists.txt staging/knotifications/cmake/FindDBusMenuQt5.cmake staging/knotifications/src/CMakeLists.txt staging/knotifications/src/config-knotifications.h.cmake staging/knotifications/src/knotification.h staging/knotifications/src/knotification.cpp staging/knotifications/src/knotificationmanager.cpp staging/knotifications/src/knotificationmanager_p.h staging/knotifications/src/knotificationrestrictions.h staging/knotifications/src/knotificationrestrictions.cpp staging/knotifications/src/kstatusnotifieritem.h staging/knotifications/src/kstatusnotifieritem.cpp staging/knotifications/src/kstatusnotifieritemdbus_p.h staging/knotifications/src/kstatusnotifieritemdbus_p.cpp staging/knotifications/src/kstatusnotifieritemprivate_p.h staging/knotifications/src/org.freedesktop.Notifications.xml staging/knotifications/src/org.kde.KNotify.xml staging/knotifications/src/org.kde.StatusNotifierItem.xml staging/knotifications/src/org.kde.StatusNotifierWatcher.xml staging/knotifications/tests/CMakeLists.txt staging/knotifications/tests/knotificationrestrictionstest.cpp staging/knotifications/tests/kstatusnotifieritemtest.h staging/knotifications/tests/kstatusnotifieritemtest.cpp tier2/CMakeLists.txt 62faacb Diff: http://git.reviewboard.kde.org/r/112696/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1188
See http://build.kde.org/job/kdelibs_frameworks_qt5/1188/changes Changes: [aleixpol] Move KNotifications to tier2 -- [...truncated 3959 lines...] [ 27%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/kauthaction.cpp.o [ 27%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/kauthactionreply.cpp.o Scanning dependencies of target KCrash [ 27%] [ 28%] Building CXX object tier2/kcrash/src/CMakeFiles/KCrash.dir/kcrash.cpp.o Building C object tier2/kcrash/src/CMakeFiles/KCrash.dir/strlcpy-fake.c.o [ 28%] Building CXX object tier1/kwidgetsaddons/src/CMakeFiles/KWidgetsAddons.dir/kviewstatemaintainerbase.cpp.o [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakeopticaldisc.cpp.o [ 28%] Generating authadaptor.moc [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakevolume.cpp.o [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakesmartcardreader.cpp.o Scanning dependencies of target KI18n [ 28%] Building CXX object staging/ki18n/src/CMakeFiles/KI18n.dir/klocalizedstring.cpp.o Scanning dependencies of target kauth_tests_static [ 28%] Building CXX object tier2/kauth/autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthaction.cpp.o [ 28%] Building CXX object tier2/kauth/autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthactionreply.cpp.o [ 28%] Building CXX object tier2/kauth/autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthexecutejob.cpp.o [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/shared/rootdevice.cpp.o [ 28%] Building CXX object tier1/kwidgetsaddons/src/CMakeFiles/KWidgetsAddons.dir/keditlistwidget.cpp.o [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakeportablemediaplayer.cpp.o [ 28%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/kauthexecutejob.cpp.o [ 28%] Building CXX object staging/ki18n/src/CMakeFiles/KI18n.dir/kcatalog.cpp.o [ 28%] Building CXX object tier2/kcrash/src/CMakeFiles/KCrash.dir/KCrash_automoc.cpp.o [ 28%] Building CXX object tier1/kwidgetsaddons/src/CMakeFiles/KWidgetsAddons.dir/kcursor.cpp.o [ 28%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/kauthobjectdecorator.cpp.o [ 28%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/AuthBackend.cpp.o [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakeprocessor.cpp.o [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/shared/cpufeatures.cpp.o Linking CXX shared library libKCrash.so [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/utils.cpp.o [ 28%] Building CXX object staging/ki18n/src/CMakeFiles/KI18n.dir/kuitmarkup.cpp.o [ 29%] Building CXX object staging/ki18n/src/CMakeFiles/KI18n.dir/common_helpers.cpp.o [ 29%] Built target KCrash [ 29%] Building CXX object tier2/kauth/autotests/CMakeFiles/kauth_tests_static.dir/__/src/AuthBackend.cpp.o [ 29%] Building CXX object tier1/kwidgetsaddons/src/CMakeFiles/KWidgetsAddons.dir/kratingwidget.cpp.o [ 29%] Building CXX object tier1/kwidgetsaddons/src/CMakeFiles/KWidgetsAddons.dir/kratingpainter.cpp.o [ 29%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/BackendsManager.cpp.o [ 29%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/HelperProxy.cpp.o [ 29%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakestorage.cpp.o [ 29%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakestorageaccess.cpp.o [ 29%] Building CXX object staging/ki18n/src/CMakeFiles/KI18n.dir/KI18n_automoc.cpp.o [ 29%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevdevice.cpp.o [ 29%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevmanager.cpp.o [ 29%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevdeviceinterface.cpp.o Linking CXX shared library libKI18n.so [ 29%] Building CXX object tier2/kauth/autotests/CMakeFiles/kauth_tests_static.dir/BackendsManager.cpp.o In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwidgetsaddons/src/kratingwidget.cpp:299:0: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kwidgetsaddons/src/moc_kratingwidget.cpp: In static member function ‘static void KRatingWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kwidgetsaddons/src/moc_kratingwidget.cpp:144:67: warning: ‘void KRatingWidget::setRating(unsigned int)’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwidgetsaddons/src/kratingwidget.cpp:155) [-Wdeprecated-declarations]
Re: Review Request 112710: Move KIO::NetAccess to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- (Updated Sept. 13, 2013, 11:42 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Description --- Move KIO::NetAccess to kde4support. I have also added @deprecated to all the functions that did not have with the exception of fish_execute that I'm unsure if we want to provide an alternative for that (since it will always be dependent on a slave...). Also, I haven't added KDE4SUPPORT_DEPREACTED_EXPORT to all methods, that would add too much noise when compiling other modules... we have to find a better solution to deprecate all kde4support. Diffs - kio/CMakeLists.txt d44dcc2 kio/kio/netaccess.h 11a4ac9 kio/kio/netaccess.cpp kio/tests/CMakeLists.txt 1874712 kio/tests/fileundomanagertest.cpp 5f5fb27 kio/tests/jobguitest.cpp ec65942 kio/tests/jobremotetest.cpp ce99ff4 kio/tests/kdirmodeltest.cpp 256d32e kio/tests/netaccesstest.cpp staging/kde4support/src/CMakeLists.txt 466c195 staging/kde4support/tests/CMakeLists.txt 2c38f46 Diff: http://git.reviewboard.kde.org/r/112710/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112710: Move KIO::NetAccess to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39955 --- This review has been submitted with commit 4cb177ae494e04a250bdcd4088777e42ab275626 by Àlex Fiestas to branch frameworks. - Commit Hook On Sept. 13, 2013, 11:21 a.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- (Updated Sept. 13, 2013, 11:21 a.m.) Review request for KDE Frameworks and David Faure. Description --- Move KIO::NetAccess to kde4support. I have also added @deprecated to all the functions that did not have with the exception of fish_execute that I'm unsure if we want to provide an alternative for that (since it will always be dependent on a slave...). Also, I haven't added KDE4SUPPORT_DEPREACTED_EXPORT to all methods, that would add too much noise when compiling other modules... we have to find a better solution to deprecate all kde4support. Diffs - kio/CMakeLists.txt d44dcc2 kio/kio/netaccess.h 11a4ac9 kio/kio/netaccess.cpp kio/tests/CMakeLists.txt 1874712 kio/tests/fileundomanagertest.cpp 5f5fb27 kio/tests/jobguitest.cpp ec65942 kio/tests/jobremotetest.cpp ce99ff4 kio/tests/kdirmodeltest.cpp 256d32e kio/tests/netaccesstest.cpp staging/kde4support/src/CMakeLists.txt 466c195 staging/kde4support/tests/CMakeLists.txt 2c38f46 Diff: http://git.reviewboard.kde.org/r/112710/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdelibs_frameworks_qt5 #1189
See http://build.kde.org/job/kdelibs_frameworks_qt5/1189/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #1191
See http://build.kde.org/job/kdelibs_frameworks_qt5/1191/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112715: Move KI18n to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- Review request for KDE Frameworks and Chusslove Illich. Description --- Moves KI18n to the tier2. Diffs - staging/CMakeLists.txt a2f2b69 staging/ki18n/.gitignore staging/ki18n/CMakeLists.txt eeadce1 staging/ki18n/KI18nConfig.cmake.in staging/ki18n/Mainpage.dox staging/ki18n/autotests/CMakeLists.txt staging/ki18n/autotests/klocalizedstringtest.h staging/ki18n/autotests/klocalizedstringtest.cpp staging/ki18n/autotests/po/fr/ki18n-test-qt.po staging/ki18n/autotests/po/fr/ki18n-test.po staging/ki18n/doxygen.cfg staging/ki18n/doxygen.css staging/ki18n/src/CMakeLists.txt staging/ki18n/src/Messages.sh staging/ki18n/src/common_helpers.cpp staging/ki18n/src/common_helpers_p.h staging/ki18n/src/gettext.h staging/ki18n/src/kcatalog.cpp staging/ki18n/src/kcatalog_p.h staging/ki18n/src/klocalizedstring.h staging/ki18n/src/klocalizedstring.cpp staging/ki18n/src/ktranscript.cpp staging/ki18n/src/ktranscript_p.h staging/ki18n/src/kuitmarkup.h staging/ki18n/src/kuitmarkup.cpp staging/ki18n/src/kuitmarkup_p.h tier2/CMakeLists.txt f88af0c Diff: http://git.reviewboard.kde.org/r/112715/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112685: Fix KWindowSystem::setMainWindow
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/#review39966 --- Ship it! Looks good to me. - Martin Gräßlin On Sept. 12, 2013, 5:20 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/ --- (Updated Sept. 12, 2013, 5:20 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Description --- Due to changes in the way Qt5 handles windows, old code was not working anymore (Qt::WA_X11BypassTransientForHint attribute is ignored by Qt5). New code takes advantage of Qt5 support for handling foreign windows provided by QWindow::fromWinId(). Diffs - tier1/kwindowsystem/CMakeLists.txt 3db68d5 tier1/kwindowsystem/src/kwindowsystem_x11.cpp bcfaf17 tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/tests/setmainwindowtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112685/diff/ Testing --- Added a new manual test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39967 --- This review has been submitted with commit 0be299aa017f717926fc0f342fc13d217c2a5353 by Martin Gräßlin to branch frameworks. - Commit Hook On Sept. 12, 2013, 1:30 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/ --- (Updated Sept. 12, 2013, 1:30 p.m.) Review request for KDE Frameworks, David Faure and Aurélien Gâteau. Description --- updateUserTimestamp() used to fetch the current time by creating a property notify event and wait till it is received by inspecting the XEvent queue. That doesn't work with XCB anymore, but Qt provides this functionality for us, so just use that. At the same time the argument is changed from int to unsigned long as that's what the method in QX11Info returns. Diffs - staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f Diff: http://git.reviewboard.kde.org/r/112684/diff/ Testing --- compiles. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs_frameworks_qt5 #1192
See http://build.kde.org/job/kdelibs_frameworks_qt5/1192/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Templates for frameworks CMake files
On Friday 13 September 2013 11:30:32 Aurélien Gâteau wrote: Hi, I have been playing around with itemviews CMake files and put together some templates for the top level CMakeLists.txt and *Config.cmake.in. You can find them attached there. Any one against me adding those to the repository? As pointed out by krop on IRC, FooBarConfigVersion.cmake.in should really be FooBarConfig.cmake.in. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Fwd: Binary incompatible change in dev branch.
--- Forwarded message (begin) Subject: Binary incompatible change in dev branch. From: Stephen Kelly stephen.ke...@kdab.com Date: Fri, 13 Sep 2013 16:52:14 +0200 Newsgroup: gmane.comp.lib.qt.devel Hello, Two changes which are binary incompatible compared to the state before them were just merged to dev: https://codereview.qt-project.org/#change,65263 https://codereview.qt-project.org/#change,65042 The changes are to APIs which were not present in Qt 5.1. This is a heads-up that you may need to re-build everything the next time you update your qtbase repo. Thanks, -- Join us in October at Qt Developer Days 2013 - https://devdays.kdab.com Stephen Kelly stephen.ke...@kdab.com | Software Engineer KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-Independent Software Solutions --- Forwarded message (end) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112556: Move itemviews to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 13, 2013, 5:02 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Description --- In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within kdelibs. Diffs - staging/CMakeLists.txt f0b6bf0 staging/itemviews/CMakeLists.txt f5c3c8d staging/itemviews/ItemViewsConfig.cmake.in c10f49f staging/itemviews/autotests/CMakeLists.txt staging/itemviews/autotests/klistwidgetsearchlinetest.cpp staging/itemviews/src/CMakeLists.txt staging/itemviews/src/kcategorizedsortfilterproxymodel.h staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h staging/itemviews/src/kcategorizedview.h staging/itemviews/src/kcategorizedview.cpp staging/itemviews/src/kcategorizedview_p.h staging/itemviews/src/kcategorydrawer.h staging/itemviews/src/kcategorydrawer.cpp staging/itemviews/src/kextendableitemdelegate.h staging/itemviews/src/kextendableitemdelegate.cpp staging/itemviews/src/kfilterproxysearchline.h staging/itemviews/src/kfilterproxysearchline.cpp staging/itemviews/src/klistwidgetsearchline.h staging/itemviews/src/klistwidgetsearchline.cpp staging/itemviews/src/ktreewidgetsearchline.h staging/itemviews/src/ktreewidgetsearchline.cpp staging/itemviews/src/kwidgetitemdelegate.h staging/itemviews/src/kwidgetitemdelegate.cpp staging/itemviews/src/kwidgetitemdelegate_p.h staging/itemviews/src/kwidgetitemdelegatepool.cpp staging/itemviews/src/kwidgetitemdelegatepool_p.h staging/itemviews/tests/CMakeLists.txt staging/itemviews/tests/kcategorizedviewtest.cpp staging/itemviews/tests/ktreewidgetsearchlinetest.h staging/itemviews/tests/ktreewidgetsearchlinetest.cpp staging/itemviews/tests/kwidgetitemdelegatetest.cpp tier2/CMakeLists.txt 62faacb Diff: http://git.reviewboard.kde.org/r/112556/diff/ Testing --- Builds and passes tests when build from kdelibs and standalone. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112685: Fix KWindowSystem::setMainWindow
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/#review39978 --- This review has been submitted with commit dbeae027d76c0215aeadf35f8a43c101fb54af0b by Aurélien Gâteau to branch frameworks. - Commit Hook On Sept. 12, 2013, 3:20 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/ --- (Updated Sept. 12, 2013, 3:20 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Description --- Due to changes in the way Qt5 handles windows, old code was not working anymore (Qt::WA_X11BypassTransientForHint attribute is ignored by Qt5). New code takes advantage of Qt5 support for handling foreign windows provided by QWindow::fromWinId(). Diffs - tier1/kwindowsystem/CMakeLists.txt 3db68d5 tier1/kwindowsystem/src/kwindowsystem_x11.cpp bcfaf17 tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/tests/setmainwindowtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112685/diff/ Testing --- Added a new manual test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112685: Fix KWindowSystem::setMainWindow
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/ --- (Updated Sept. 13, 2013, 3:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Description --- Due to changes in the way Qt5 handles windows, old code was not working anymore (Qt::WA_X11BypassTransientForHint attribute is ignored by Qt5). New code takes advantage of Qt5 support for handling foreign windows provided by QWindow::fromWinId(). Diffs - tier1/kwindowsystem/CMakeLists.txt 3db68d5 tier1/kwindowsystem/src/kwindowsystem_x11.cpp bcfaf17 tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/tests/setmainwindowtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112685/diff/ Testing --- Added a new manual test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 3:33 p.m.) Status -- This change has been discarded. Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/ --- (Updated Sept. 13, 2013, 5:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Expose setStandardActionNames as public API in kacceleratormanager This is needed by KStandardAction which is in a different tier to kacceleratormanager. I changed it from setStandardActionNames to addStandardActionNames as now it it public API it shouldn't break if two classes use it. Diffs - staging/kconfigwidgets/src/kstandardaction.cpp 23e3b32 tier1/kwidgetsaddons/src/kacceleratormanager.h 108cb85 tier1/kwidgetsaddons/src/kacceleratormanager.cpp f50057e tier1/kwidgetsaddons/src/kacceleratormanager_p.h 89ccde5 Diff: http://git.reviewboard.kde.org/r/112673/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112717: Start adopting QCollator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau. Description --- Now that QCollator is public API, I wanted to give it a try, so I decided to port all uses KStringHandler::naturalCompare() to QCollator. All the porting was quite straightforward I'd say, the only weird part is that I removed some tests of the KStringHandler tests. There are 2 kind of tests disabled: - The ones that say that A == a in case of Qt::CaseInsensitive. ICU is deterministic and it will decide itself which one goes in, so the test doesn't make sense anymore. - There's a mention to the 237788 bug where in some cases our former algorithm wouldn't be deterministic. This doesn't apply anymore, but also now ICU takes care about it now, so there's little point of keeping unit testing it. I decided to leave the unit test because it might be useful eventually (although note that it was not being compiled so far). In any case we probably want it out. In any case, the rest seems straightforward enough. I didn't concentrate on performance though, in some cases we'll want to use the QCollatorSortKey. Diffs - KDE5PORTING.html 1287de7 kfile/kdirsortfilterproxymodel.cpp 7c7aa5f kfile/kurlnavigatorbutton.cpp d2c27fd staging/itemviews/src/CMakeLists.txt 353a413 staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b staging/kcompletion/src/kcompletion.cpp 5f60a6c staging/xmlgui/src/kshortcutsdialog_p.h ab102bc staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa Diff: http://git.reviewboard.kde.org/r/112717/diff/ Testing --- Builds, affected tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/#review39985 --- This review has been submitted with commit e8e401e317c4bd526a890a87687b75a14aeefc8e by David Edmundson to branch frameworks. - Commit Hook On Sept. 11, 2013, 4:52 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/ --- (Updated Sept. 11, 2013, 4:52 p.m.) Review request for KDE Frameworks. Description --- Expose setStandardActionNames as public API in kacceleratormanager This is needed by KStandardAction which is in a different tier to kacceleratormanager. I changed it from setStandardActionNames to addStandardActionNames as now it it public API it shouldn't break if two classes use it. Diffs - staging/kconfigwidgets/src/kstandardaction.cpp 23e3b32 tier1/kwidgetsaddons/src/kacceleratormanager.h 108cb85 tier1/kwidgetsaddons/src/kacceleratormanager.cpp f50057e tier1/kwidgetsaddons/src/kacceleratormanager_p.h 89ccde5 Diff: http://git.reviewboard.kde.org/r/112673/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112717: Start adopting QCollator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review39986 --- That's a very impressive part on the porting side! Thank you very much for taking care here. I have some experience in optimizing this function (understatement ^_^) and know very well that even a tiny change in performace (negative or positive) can have a big impact on sorting large folders in Dolphin. You really should measure the performance and see if it beats the current stuff, if it does then it should deffinately replace naturalCompare :) - Mark Gaiser On Sept. 13, 2013, 5:12 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- (Updated Sept. 13, 2013, 5:12 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau. Description --- Now that QCollator is public API, I wanted to give it a try, so I decided to port all uses KStringHandler::naturalCompare() to QCollator. All the porting was quite straightforward I'd say, the only weird part is that I removed some tests of the KStringHandler tests. There are 2 kind of tests disabled: - The ones that say that A == a in case of Qt::CaseInsensitive. ICU is deterministic and it will decide itself which one goes in, so the test doesn't make sense anymore. - There's a mention to the 237788 bug where in some cases our former algorithm wouldn't be deterministic. This doesn't apply anymore, but also now ICU takes care about it now, so there's little point of keeping unit testing it. I decided to leave the unit test because it might be useful eventually (although note that it was not being compiled so far). In any case we probably want it out. In any case, the rest seems straightforward enough. I didn't concentrate on performance though, in some cases we'll want to use the QCollatorSortKey. Diffs - KDE5PORTING.html 1287de7 kfile/kdirsortfilterproxymodel.cpp 7c7aa5f kfile/kurlnavigatorbutton.cpp d2c27fd staging/itemviews/src/CMakeLists.txt 353a413 staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b staging/kcompletion/src/kcompletion.cpp 5f60a6c staging/xmlgui/src/kshortcutsdialog_p.h ab102bc staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa Diff: http://git.reviewboard.kde.org/r/112717/diff/ Testing --- Builds, affected tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112715: Move KI18n to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/#review39981 --- Ship it! Ship It! - Chusslove Illich On Sept. 13, 2013, 3:19 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- (Updated Sept. 13, 2013, 3:19 p.m.) Review request for KDE Frameworks and Chusslove Illich. Description --- Moves KI18n to the tier2. Diffs - staging/CMakeLists.txt a2f2b69 staging/ki18n/.gitignore staging/ki18n/CMakeLists.txt eeadce1 staging/ki18n/KI18nConfig.cmake.in staging/ki18n/Mainpage.dox staging/ki18n/autotests/CMakeLists.txt staging/ki18n/autotests/klocalizedstringtest.h staging/ki18n/autotests/klocalizedstringtest.cpp staging/ki18n/autotests/po/fr/ki18n-test-qt.po staging/ki18n/autotests/po/fr/ki18n-test.po staging/ki18n/doxygen.cfg staging/ki18n/doxygen.css staging/ki18n/src/CMakeLists.txt staging/ki18n/src/Messages.sh staging/ki18n/src/common_helpers.cpp staging/ki18n/src/common_helpers_p.h staging/ki18n/src/gettext.h staging/ki18n/src/kcatalog.cpp staging/ki18n/src/kcatalog_p.h staging/ki18n/src/klocalizedstring.h staging/ki18n/src/klocalizedstring.cpp staging/ki18n/src/ktranscript.cpp staging/ki18n/src/ktranscript_p.h staging/ki18n/src/kuitmarkup.h staging/ki18n/src/kuitmarkup.cpp staging/ki18n/src/kuitmarkup_p.h tier2/CMakeLists.txt f88af0c Diff: http://git.reviewboard.kde.org/r/112715/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112717: Start adopting QCollator
On Sept. 13, 2013, 5:32 p.m., Mark Gaiser wrote: That's a very impressive part on the porting side! Thank you very much for taking care here. I have some experience in optimizing this function (understatement ^_^) and know very well that even a tiny change in performace (negative or positive) can have a big impact on sorting large folders in Dolphin. You really should measure the performance and see if it beats the current stuff, if it does then it should deffinately replace naturalCompare :) Note that the change to QCollator is not about performance, but it's about properly listing things in different locales. In any case, QCollatorSortKey should really help. If you have some stress test I can run, I'll be glad to try it. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review39986 --- On Sept. 13, 2013, 5:12 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- (Updated Sept. 13, 2013, 5:12 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau. Description --- Now that QCollator is public API, I wanted to give it a try, so I decided to port all uses KStringHandler::naturalCompare() to QCollator. All the porting was quite straightforward I'd say, the only weird part is that I removed some tests of the KStringHandler tests. There are 2 kind of tests disabled: - The ones that say that A == a in case of Qt::CaseInsensitive. ICU is deterministic and it will decide itself which one goes in, so the test doesn't make sense anymore. - There's a mention to the 237788 bug where in some cases our former algorithm wouldn't be deterministic. This doesn't apply anymore, but also now ICU takes care about it now, so there's little point of keeping unit testing it. I decided to leave the unit test because it might be useful eventually (although note that it was not being compiled so far). In any case we probably want it out. In any case, the rest seems straightforward enough. I didn't concentrate on performance though, in some cases we'll want to use the QCollatorSortKey. Diffs - KDE5PORTING.html 1287de7 kfile/kdirsortfilterproxymodel.cpp 7c7aa5f kfile/kurlnavigatorbutton.cpp d2c27fd staging/itemviews/src/CMakeLists.txt 353a413 staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b staging/kcompletion/src/kcompletion.cpp 5f60a6c staging/xmlgui/src/kshortcutsdialog_p.h ab102bc staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa Diff: http://git.reviewboard.kde.org/r/112717/diff/ Testing --- Builds, affected tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112715: Move KI18n to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- (Updated Sept. 13, 2013, 6:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Description --- Moves KI18n to the tier2. Diffs - staging/CMakeLists.txt a2f2b69 staging/ki18n/.gitignore staging/ki18n/CMakeLists.txt eeadce1 staging/ki18n/KI18nConfig.cmake.in staging/ki18n/Mainpage.dox staging/ki18n/autotests/CMakeLists.txt staging/ki18n/autotests/klocalizedstringtest.h staging/ki18n/autotests/klocalizedstringtest.cpp staging/ki18n/autotests/po/fr/ki18n-test-qt.po staging/ki18n/autotests/po/fr/ki18n-test.po staging/ki18n/doxygen.cfg staging/ki18n/doxygen.css staging/ki18n/src/CMakeLists.txt staging/ki18n/src/Messages.sh staging/ki18n/src/common_helpers.cpp staging/ki18n/src/common_helpers_p.h staging/ki18n/src/gettext.h staging/ki18n/src/kcatalog.cpp staging/ki18n/src/kcatalog_p.h staging/ki18n/src/klocalizedstring.h staging/ki18n/src/klocalizedstring.cpp staging/ki18n/src/ktranscript.cpp staging/ki18n/src/ktranscript_p.h staging/ki18n/src/kuitmarkup.h staging/ki18n/src/kuitmarkup.cpp staging/ki18n/src/kuitmarkup_p.h tier2/CMakeLists.txt f88af0c Diff: http://git.reviewboard.kde.org/r/112715/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- Review request for KDE Frameworks and David Faure. Description --- In KF5, KAuthorized was split into two: KCoreAuthorized, in KConfig, and KAuthorized, in KIO. Despite the name, KCoreAuthorized offers functions in the KAuthorized namespace, and KAuthorized extends it with additional functions that require KIO APIs. This causes the following problems: * The majority of users of the framework want to use the functions offered in KCoreAuthorized, but when they include kcoreauthorized.h, they have to use the KAuthorized namespace to access them. This sort of non-mapping is bad for the brain :). * While kauthorized.h remaining available via KIO succeds in preserving SC, it does so by muddled-up lib dependencies: Stuff that doesn't actually need KIO might end up linking to it just to avoid changing sources, or just because someone greps for KAuthorized and finds the copy in KIO (this is what happened to me in the Task Manager and made me investigate). The proposed patch does the following to address this: * KCoreAuthorized in KConfig is renamed to KAuthorized. This fixes the include-to-namespace mapping problem and continues to preserve SC for the majority of users. * KAuthorized in KIO is renamed to KUrlAuthorized to hold the URL/KIO-specific functions. This means the few users of those functions (e.g. KHTML) need to be ported to a new include name, but SC is retained via the same namespace. (I think it would have been nice to offer them in a KUrlAuthorized namespace to avoid the include-to-namespace mapping problem here too, but this is complicated by wanting to call non-public symbols expoted by K(Core)Authorized ... ideas welcome.) The bottom line is that this avoids users linking to the wrong API for no reason and continues to preserve SC for the majority of users while unfortunately causing porting effort for some users. Most existing users will be unaffected and gain the ability to stop linking KIO if they don't need it. New users won't be confused over why something as canonical-sounding as KAuthorized is in KIO. The alternative would have been to keep the KCoreAuthorized and KAuthorized names and locations, and add forwarders with deprecation notices to KAuthorized for the functions offered in KCoreAuthorized. However, this would mean duplication and a lot of porting churn away from deprecated API, and in the meantime not address the linking issue. This change was discussed with and tentatively agreed upon (pre-code) by dfaure. Diffs - includes/CMakeLists.txt bcd3789 kfile/kdirselectdialog.cpp ac4a194 kfile/kfilewidget.cpp 4901fcd khtml/java/kjavaappletviewer.cpp b10d993 khtml/khtml_part.cpp b0e31ce khtml/misc/loader.cpp cf451be khtml/xml/dom_docimpl.cpp 2b6125d kio/kfile/kpropertiesdialog.cpp 359ffab kio/misc/ktelnetservice.cpp 1c0d517 kutils/kcmultidialog.cpp 5286866 staging/kbookmarks/src/kbookmarkmenu.cc 6c1569c staging/kcompletion/src/klineedit.cpp 76ef377 staging/kde4support/src/kdeui/kapplication.cpp 12092e9 staging/kio/src/core/CMakeLists.txt 4897d5f staging/kio/src/core/job.cpp 511d1cc staging/kio/src/core/kauthorized.h 473725d staging/kio/src/core/kauthorized.cpp b930715 staging/kio/src/core/kurlauthorized.h PRE-CREATION staging/kio/src/core/kurlauthorized.cpp PRE-CREATION staging/kio/src/core/mkdirjob.cpp 9ed00b0 staging/kio/src/widgets/accessmanagerreply_p.cpp ad9b4f7 staging/kio/src/widgets/kfileitemactions.cpp 99d3209 staging/kio/src/widgets/kopenwithdialog.cpp b46e1ee staging/kio/src/widgets/krun.cpp aba4d7a staging/kio/src/widgets/kurlcompletion.cpp 80a4023 staging/kservice/src/services/kservice.cpp dea8618 staging/xmlgui/src/kactioncollection.cpp 5085f53 staging/xmlgui/src/khelpmenu.cpp cfc52a0 staging/xmlgui/src/ktoolbar.cpp 6a59874 staging/xmlgui/src/ktoolbarhandler.cpp 162de5a staging/xmlgui/src/kxmlguibuilder.cpp 6eb8a51 staging/xmlgui/src/kxmlguiclient.cpp 809033f tier1/kconfig/src/core/CMakeLists.txt 51e21ff tier1/kconfig/src/core/kauthorized.h PRE-CREATION tier1/kconfig/src/core/kauthorized.cpp PRE-CREATION tier1/kconfig/src/core/kcoreauthorized.h 2a3d79e tier1/kconfig/src/core/kcoreauthorized.cpp 97cbc79 tier1/kconfig/src/core/kdesktopfile.cpp a0d5cb8 Diff: http://git.reviewboard.kde.org/r/112722/diff/ Testing --- Thanks, Eike Hein ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- (Updated Sept. 13, 2013, 11:38 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Whoops, one replace too many. Description --- In KF5, KAuthorized was split into two: KCoreAuthorized, in KConfig, and KAuthorized, in KIO. Despite the name, KCoreAuthorized offers functions in the KAuthorized namespace, and KAuthorized extends it with additional functions that require KIO APIs. This causes the following problems: * The majority of users of the framework want to use the functions offered in KCoreAuthorized, but when they include kcoreauthorized.h, they have to use the KAuthorized namespace to access them. This sort of non-mapping is bad for the brain :). * While kauthorized.h remaining available via KIO succeds in preserving SC, it does so by muddled-up lib dependencies: Stuff that doesn't actually need KIO might end up linking to it just to avoid changing sources, or just because someone greps for KAuthorized and finds the copy in KIO (this is what happened to me in the Task Manager and made me investigate). The proposed patch does the following to address this: * KCoreAuthorized in KConfig is renamed to KAuthorized. This fixes the include-to-namespace mapping problem and continues to preserve SC for the majority of users. * KAuthorized in KIO is renamed to KUrlAuthorized to hold the URL/KIO-specific functions. This means the few users of those functions (e.g. KHTML) need to be ported to a new include name, but SC is retained via the same namespace. (I think it would have been nice to offer them in a KUrlAuthorized namespace to avoid the include-to-namespace mapping problem here too, but this is complicated by wanting to call non-public symbols expoted by K(Core)Authorized ... ideas welcome.) The bottom line is that this avoids users linking to the wrong API for no reason and continues to preserve SC for the majority of users while unfortunately causing porting effort for some users. Most existing users will be unaffected and gain the ability to stop linking KIO if they don't need it. New users won't be confused over why something as canonical-sounding as KAuthorized is in KIO. The alternative would have been to keep the KCoreAuthorized and KAuthorized names and locations, and add forwarders with deprecation notices to KAuthorized for the functions offered in KCoreAuthorized. However, this would mean duplication and a lot of porting churn away from deprecated API, and in the meantime not address the linking issue. This change was discussed with and tentatively agreed upon (pre-code) by dfaure. Diffs (updated) - includes/CMakeLists.txt bcd3789 kfile/kdirselectdialog.cpp ac4a194 kfile/kfilewidget.cpp 4901fcd khtml/java/kjavaappletviewer.cpp b10d993 khtml/khtml_part.cpp b0e31ce khtml/misc/loader.cpp cf451be khtml/xml/dom_docimpl.cpp 2b6125d kio/kfile/kpropertiesdialog.cpp 359ffab kio/misc/ktelnetservice.cpp 1c0d517 kutils/kcmultidialog.cpp 5286866 staging/kbookmarks/src/kbookmarkmenu.cc 6c1569c staging/kcompletion/src/klineedit.cpp 76ef377 staging/kde4support/src/kdeui/kapplication.cpp 12092e9 staging/kio/src/core/CMakeLists.txt 4897d5f staging/kio/src/core/job.cpp 511d1cc staging/kio/src/core/kauthorized.h 473725d staging/kio/src/core/kauthorized.cpp b930715 staging/kio/src/core/kurlauthorized.h PRE-CREATION staging/kio/src/core/kurlauthorized.cpp PRE-CREATION staging/kio/src/core/mkdirjob.cpp 9ed00b0 staging/kio/src/widgets/accessmanagerreply_p.cpp ad9b4f7 staging/kio/src/widgets/kfileitemactions.cpp 99d3209 staging/kio/src/widgets/kopenwithdialog.cpp b46e1ee staging/kio/src/widgets/krun.cpp aba4d7a staging/kio/src/widgets/kurlcompletion.cpp 80a4023 staging/kservice/src/services/kservice.cpp dea8618 staging/xmlgui/src/kactioncollection.cpp 5085f53 staging/xmlgui/src/khelpmenu.cpp cfc52a0 staging/xmlgui/src/ktoolbar.cpp 6a59874 staging/xmlgui/src/ktoolbarhandler.cpp 162de5a staging/xmlgui/src/kxmlguibuilder.cpp 6eb8a51 staging/xmlgui/src/kxmlguiclient.cpp 809033f tier1/kconfig/src/core/CMakeLists.txt 51e21ff tier1/kconfig/src/core/kauthorized.h PRE-CREATION tier1/kconfig/src/core/kauthorized.cpp PRE-CREATION tier1/kconfig/src/core/kcoreauthorized.h 2a3d79e tier1/kconfig/src/core/kcoreauthorized.cpp 97cbc79 tier1/kconfig/src/core/kdesktopfile.cpp a0d5cb8 Diff: http://git.reviewboard.kde.org/r/112722/diff/ Testing --- Thanks, Eike Hein ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
