KEmailSettings and ksendbugmail

2013-11-03 Thread David Faure
KEmailSettings has historically been in KIO. It's however, just a bunch of KConfig calls. ksendbugmail is a separate program used by tier3/xmlgui/src/kbugreport.cpp and it needs KEmailSettings (and in kde4 it didn't even link to kio for that, it just compiled that file alone from the kio

Jenkins build became unstable: kdelibs_frameworks_qt5 #1569

2013-11-03 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1569/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1571

2013-11-03 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1571/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Getting ecm files from the ECM package

2013-11-03 Thread Kevin Ottens
On Saturday 02 November 2013 21:12:08 David Faure wrote: On Saturday 02 November 2013 13:44:55 Stephen Kelly wrote: Alexander Neundorf wrote: In case we decide to go this way (i.e. the my ideal view plus optional downloading), and we should hear Stephens opinion on that, My opinion:

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-11-03 Thread Kevin Ottens
On Oct. 14, 2013, 9:05 a.m., Kevin Ottens wrote: I'm not sold on bastardizing QErrorMessage for that feature. The intent was more to have some code similar to what KDialogQueue (moved to KDE4Support) was doing directly in KDialogJobUiDelegate implementation. David Faure wrote:

Re: Getting ecm files from the ECM package

2013-11-03 Thread Alexander Neundorf
On Saturday 02 November 2013, Luca Beltrame wrote: Rex Dieter wrote: I can vouche for fedora/redhat that the buildsystem does not have internet access. Likewise, the OBS for openSUSE does not have net access during building. as I said, it is trivial and IMO mandatory to have that

Re: Getting ecm files from the ECM package

2013-11-03 Thread Alexander Neundorf
On Friday 01 November 2013, Sune Vuorela wrote: On 2013-11-01, Alexander Neundorf neund...@kde.org wrote: Anyway, attached is a quick experiment, which adds the 3 KDE*.cmake files= from=20 extra-cmake-modules/ to kf5umbrella/, by that turning it into tier0/, wit= h the=20

Re: Getting ecm files from the ECM package

2013-11-03 Thread Alexander Neundorf
On Saturday 02 November 2013, Stephen Kelly wrote: Alexander Neundorf wrote: In case we decide to go this way (i.e. the my ideal view plus optional downloading), and we should hear Stephens opinion on that, My opinion: 1) The current situation with ECM and KF5 is just fine. do you

Re: Getting ecm files from the ECM package

2013-11-03 Thread Stephen Kelly
Alexander Neundorf wrote: e.g. keeping code like always, unconditional, hardcoded searching for QtCore 'hardcoded' doesn't have any meaning in this context. The code you are talking about is neither 'always', nor 'unconditional'. if(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.13)

Re: Getting ecm files from the ECM package

2013-11-03 Thread Kevin Ottens
On Sunday 03 November 2013 14:05:32 Alexander Neundorf wrote: On Saturday 02 November 2013, David Faure wrote: On Saturday 02 November 2013 13:44:55 Stephen Kelly wrote: Alexander Neundorf wrote: In case we decide to go this way (i.e. the my ideal view plus optional downloading), and

Re: Getting ecm files from the ECM package

2013-11-03 Thread Alexander Neundorf
On Sunday 03 November 2013, Stephen Kelly wrote: Alexander Neundorf wrote: e.g. keeping code like always, unconditional, hardcoded searching for QtCore 'hardcoded' doesn't have any meaning in this context. The code you are talking about is neither 'always', nor 'unconditional'. come

Re: Getting ecm files from the ECM package

2013-11-03 Thread Alexander Neundorf
On Sunday 03 November 2013, Kevin Ottens wrote: On Sunday 03 November 2013 14:05:32 Alexander Neundorf wrote: ... To build software using an installed karchive, they don't need anything but a compiler. To build software using karchive with cmake, they still need only cmake. To build

Review Request 113589: Allow test-kconf_update to run before kconfig is installed

2013-11-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113510: Deprecate methods in kimageio

2013-11-03 Thread Alex Merry
On 02/11/13 23:09, David Faure wrote: On Saturday 02 November 2013 22:36:03 Alex Merry wrote: On 02/11/13 19:36, David Faure wrote: If we want to get rid of the .desktop files, why don't we just implement KImageIO on top of QImageReader/Writer, rather than duplicate its code? Only that

Review Request 113586: More general warning cleanups

2013-11-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Getting ecm files from the ECM package

2013-11-03 Thread Sune Vuorela
On 2013-11-03, Alexander Neundorf neund...@kde.org wrote: This code unconditionally searches for QtCore (and sets a target property where I'm not sure how many people here can understand what's going on). It is hopefully a temporary hack that shouldn't be in that file. Sometimes, temporary

Re: Exceptions in KDE Frameworks

2013-11-03 Thread Sune Vuorela
On 2013-11-02, Mirko Boehm mi...@kde.org wrote: I get from that that I can enable exceptions for threadweaver without affecting the other libraries. This makes my job a lot easier. note though that most of Qt isn't really compatiple with exceptions. see also long threads on qt-dev list. /Sune

Re: Getting ecm files from the ECM package

2013-11-03 Thread Stephen Kelly
Sune Vuorela wrote: On 2013-11-03, Alexander Neundorf neund...@kde.org wrote: This code unconditionally searches for QtCore (and sets a target property where I'm not sure how many people here can understand what's going on). It is hopefully a temporary hack that shouldn't be in that file.

Re: Getting ecm files from the ECM package

2013-11-03 Thread Alexander Neundorf
On Sunday 03 November 2013, Sune Vuorela wrote: On 2013-11-03, Alexander Neundorf neund...@kde.org wrote: This code unconditionally searches for QtCore (and sets a target property where I'm not sure how many people here can understand what's going on). It is hopefully a temporary hack that

Re: Getting ecm files from the ECM package

2013-11-03 Thread Stephen Kelly
Alexander Neundorf wrote: On Sunday 03 November 2013, Sune Vuorela wrote: On 2013-11-03, Alexander Neundorf neund...@kde.org wrote: This code unconditionally searches for QtCore (and sets a target property where I'm not sure how many people here can understand what's going on). It is

Re: Review Request 113507: Use ecm_mark_as_test for test-only targets

2013-11-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113507/#review42914 --- This review has been submitted with commit

Re: Review Request 113507: Use ecm_mark_as_test for test-only targets

2013-11-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113507/ --- (Updated Nov. 3, 2013, 9:59 p.m.) Status -- This change has been

Jenkins build is back to normal : plasma-framework_master_qt5 #886

2013-11-03 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/886/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Nov. 4, 2013, 6:45 a.m.) Status -- This change has been

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-11-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42924 --- This review has been submitted with commit