---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115716/
---
Review request for KDE Frameworks.
Repository: kinit
Description
Hi,
on my quest to ensure that we can run all applications with -platform wayland
if compiled with X11 support I stumbled over kinit/kdeinit/kinit.cpp which
gets compiled into the kdeinit5 binary. To quote the code:
// Can't use QGuiApplication::platformName() here, there is no app instance
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115713/#review49701
---
Ship it!
Ship It!
- Marco Martin
On Feb. 13, 2014, 6:53
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/
---
Review request for KDE Frameworks.
Repository: kdesu
Description
On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote:
fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html ,
supporting vendor prefixes are not only a good idea, but is strongly
encouraged. ... it is recommended that providers of desktop-files ensure
that all desktop-file
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115695/
---
(Updated Feb. 13, 2014, 11:14 a.m.)
Review request for kde-workspace,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115704/#review49705
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115704/
---
(Updated Feb. 13, 2014, 10:19 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115719/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115721/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/
---
Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote:
Well the platform name was added for compatibility with what Firefox at the
time. And Chromium seems to have adapted that as well.
The latest stable version of Firefox (version 27) for example sends the
following user agent string
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115613/
---
(Updated Feb. 13, 2014, 2:03 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115724/
---
Review request for KDE Frameworks and Marco Martin.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/#review49709
---
Ship it!
That seems like a reasonable compromise to me. I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115725/
---
Review request for KDE Frameworks and Alex Merry.
Repository: kapidox
On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote:
fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html ,
supporting vendor prefixes are not only a good idea, but is strongly
encouraged. ... it is recommended that providers of desktop-files ensure
that all desktop-file
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/
---
(Updated Feb. 13, 2014, 8:56 p.m.)
Review request for Documentation, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115739/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review49738
---
Ship it!
Just please consider the note below, then ship it!
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote:
Making the type movable does not make QList store it directly, how did you
check this?
http://qt-project.org/doc/qt-5/qlist.html says:
Internally, QListT is represented as an array of pointers to items of
type T. If T is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/#review49747
---
src/core/kprotocolmanager.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review49752
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review49751
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/
---
(Updated Feb. 13, 2014, 10:37 p.m.)
Status
--
This change has been
On Thu, February 13, 2014 02:29:21 Shivam Makkar wrote:
Hi
I'm not able to build framework 5 due to some update error in Krunner, is
there any manual method to build it ?
You can pass --no-snapshots to the kdesrc-build command line to disable the
use of a snapshot. kdesrc-build will then
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115740/#review49758
---
Ship it!
Ship It!
- Christoph Feck
On Feb. 13, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115740/
---
(Updated Feb. 13, 2014, 11:17 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115740/#review49759
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115741/
---
Review request for KDE Frameworks.
Repository: kinit
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115741/
---
(Updated Feb. 14, 2014, 12:22 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115742/
---
Review request for KDE Frameworks and kdewin.
Repository: kparts
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115743/
---
(Updated Feb. 14, 2014, 1:02 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115743/
---
Review request for KDE Frameworks.
Repository: kross
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115610/#review49761
---
Looks good to me, but it is a rather large diff, so I think
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115355/#review49762
---
cmake/FindSharedMimeInfo.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/
---
Review request for Documentation, KDE Frameworks, kdewin, and Luigi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115745/
---
Review request for KDE Frameworks and kdewin.
Repository: kservice
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115488/#review49763
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 4, 2014,
On Feb. 13, 2014, 11:27 p.m., Alexander Richardson wrote:
src/core/kprotocolmanager.cpp, line 690
https://git.reviewboard.kde.org/r/115723/diff/1/?file=243874#file243874line690
Maybe move the Q_OS_MAC up as the first check, then there is no need
for !defined(Q_OS_DARWIN)
I
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote:
Making the type movable does not make QList store it directly, how did you
check this?
http://qt-project.org/doc/qt-5/qlist.html says:
Internally, QListT is represented as an array of pointers to items of
type T. If T is
41 matches
Mail list logo