Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115716/ --- Review request for KDE Frameworks. Repository: kinit Description

X11 usage in kdeinit/kinit.cpp

2014-02-13 Thread Martin Gräßlin
Hi, on my quest to ensure that we can run all applications with -platform wayland if compiled with X11 support I stumbled over kinit/kdeinit/kinit.cpp which gets compiled into the kdeinit5 binary. To quote the code: // Can't use QGuiApplication::platformName() here, there is no app instance

Re: Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

2014-02-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/#review49701 --- Ship it! Ship It! - Marco Martin On Feb. 13, 2014, 6:53

Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115717/ --- Review request for KDE Frameworks. Repository: kdesu Description

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-13 Thread Alex Merry
On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote: fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html , supporting vendor prefixes are not only a good idea, but is strongly encouraged. ... it is recommended that providers of desktop-files ensure that all desktop-file

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 13, 2014, 11:14 a.m.) Review request for kde-workspace,

Re: Review Request 115704: Comment out kio OpenSSL dependency checks

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/#review49705 --- This review has been submitted with commit

Re: Review Request 115704: Comment out kio OpenSSL dependency checks

2014-02-13 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/ --- (Updated Feb. 13, 2014, 10:19 a.m.) Status -- This change has been

Review Request 115719: Move kio zlib dependency

2014-02-13 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115719/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/ --- Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-13 Thread Martin Gräßlin
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 13, 2014, 2:03 p.m.) Status -- This change has been

Review Request 115724: Drop version check for Qt at least being 4.7

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115724/ --- Review request for KDE Frameworks and Marco Martin. Repository:

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49709 --- Ship it! That seems like a reasonable compromise to me. I

Review Request 115725: Switch from yapgvb to Graphviz Python bindings

2014-02-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115725/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-13 Thread Rex Dieter
On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote: fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html , supporting vendor prefixes are not only a good idea, but is strongly encouraged. ... it is recommended that providers of desktop-files ensure that all desktop-file

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 8:56 p.m.) Review request for Documentation, KDE

Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49738 --- Ship it! Just please consider the note below, then ship it!

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: Making the type movable does not make QList store it directly, how did you check this? http://qt-project.org/doc/qt-5/qlist.html says: Internally, QListT is represented as an array of pointers to items of type T. If T is

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49747 --- src/core/kprotocolmanager.cpp

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49752 --- This review has been submitted with commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49751 --- This review has been submitted with commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 10:37 p.m.) Status -- This change has been

Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

2014-02-13 Thread Michael Pyne
On Thu, February 13, 2014 02:29:21 Shivam Makkar wrote: Hi I'm not able to build framework 5 due to some update error in Krunner, is there any manual method to build it ? You can pass --no-snapshots to the kdesrc-build command line to disable the use of a snapshot. kdesrc-build will then

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49758 --- Ship it! Ship It! - Christoph Feck On Feb. 13, 2014,

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/ --- (Updated Feb. 13, 2014, 11:17 p.m.) Status -- This change has been

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49759 --- This review has been submitted with commit

Review Request 115741: Fix MSVC of kinit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/ --- Review request for KDE Frameworks. Repository: kinit Description

Re: Review Request 115741: Fix MSVC of kinit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/ --- (Updated Feb. 14, 2014, 12:22 a.m.) Review request for KDE Frameworks.

Review Request 115742: KParts: Allow compilation on windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115742/ --- Review request for KDE Frameworks and kdewin. Repository: kparts

Re: Review Request 115743: Use QFunctionPointer instead of void*

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/ --- (Updated Feb. 14, 2014, 1:02 a.m.) Review request for KDE Frameworks.

Review Request 115743: Use QFunctionPointer instead of void*

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review49761 --- Looks good to me, but it is a rather large diff, so I think

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review49762 --- cmake/FindSharedMimeInfo.cmake

Review Request 115744: The WIN32 part of this if statement doesn't seem to work - drop it

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/ --- Review request for Documentation, KDE Frameworks, kdewin, and Luigi

Review Request 115745: kservice: Allow compiling with MSVC

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115745/ --- Review request for KDE Frameworks and kdewin. Repository: kservice

Re: Review Request 115488: Improve docs for kde modules

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115488/#review49763 --- Ship it! Ship It! - Alexander Richardson On Feb. 4, 2014,

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Martin Gräßlin
On Feb. 13, 2014, 11:27 p.m., Alexander Richardson wrote: src/core/kprotocolmanager.cpp, line 690 https://git.reviewboard.kde.org/r/115723/diff/1/?file=243874#file243874line690 Maybe move the Q_OS_MAC up as the first check, then there is no need for !defined(Q_OS_DARWIN) I

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Frank Reininghaus
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: Making the type movable does not make QList store it directly, how did you check this? http://qt-project.org/doc/qt-5/qlist.html says: Internally, QListT is represented as an array of pointers to items of type T. If T is