Re: [kdesrc-build] /: Use kde-runtime/frameworks instead of kde-runtime/master

2014-03-06 Thread David Faure
On Wednesday 05 March 2014 17:04:10 Àlex Fiestas wrote: Git commit ae5798e3ce2368c0561424537f77ad34d56eb61a by Àlex Fiestas. Committed on 05/03/2014 at 17:00. Pushed by afiestas into branch 'master'. Use kde-runtime/frameworks instead of kde-runtime/master M +7-1

Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/ --- Review request for Build System and KDE Frameworks. Repository:

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

2014-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52236 --- Ship it! - Aleix Pol Gonzalez On March 6, 2014, 10:11

Re: Review Request 116616: Remove unused find-modules back to the attic

2014-03-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/#review52241 --- This review has been submitted with commit

Re: Review Request 116616: Remove unused find-modules back to the attic

2014-03-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/ --- (Updated March 6, 2014, 11:50 a.m.) Status -- This change has been

Jenkins build became unstable: kitemmodels_master_qt5 #25

2014-03-06 Thread KDE CI System
See http://build.kde.org/job/kitemmodels_master_qt5/25/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KSpeech

2014-03-06 Thread Frederik Gladhorn
Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: Took a quick read through that just now and it looks pretty promising from what I saw. I guess I don't know my way around gerrit very well because I couldn't see a place to comment on the code like reviewboard. Really the only difference

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/ --- (Updated March 6, 2014, 4:30 p.m.) Status -- This change has been

Re: Review Request 116090: Use $TARGET_FILE:... instead of get_target_property(... LOCATION)

2014-03-06 Thread Aurélien Gâteau
On Feb. 27, 2014, 10:54 a.m., Alex Merry wrote: The problem with doing this in support code is that it is not strictly source compatible. An example this would break is if you want to embed the value of QT_QMAKE_EXECUTABLE into a C++ executable using something like

Review Request 116639: Do not read LOCATION property of desktoptojson

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116639/ --- Review request for Build System and KDE Frameworks. Repository: kservice

Re: Review Request 116591: Use dedicated NET::Properties and NET::Properties2 in NETWinInfo

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116591/#review52274 --- Ship it! Looks good to me. - Aurélien Gâteau On March 4,

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/#review52275 --- A few methods have mismatched params in their header

Re: KSpeech

2014-03-06 Thread Jeremy Whiting
On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn gladh...@kde.org wrote: Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: Took a quick read through that just now and it looks pretty promising from what I saw. I guess I don't know my way around gerrit very well because I couldn't see a place

Re: Review Request 116610: Use flag types in NETRootInfo

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116610/#review52277 --- Ship it! Looks good. One question though, wasn't it

Re: Review Request 116610: Use flag types in NETRootInfo

2014-03-06 Thread Martin Gräßlin
On March 6, 2014, 5:22 p.m., Aurélien Gâteau wrote: Looks good. One question though, wasn't it possible to merge properties or properties2? I lack extensive knowledge of this domain, but it looks odd from an API point of view. that would be a large SC break which might not be

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-06 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: qt5 polkit-qt-1 and kdesrc-build

2014-03-06 Thread Martin Briza
On Sat, 01 Mar 2014 16:42:31 +0100, David Faure fa...@kde.org wrote: On Wednesday 26 February 2014 22:25:01 Milian Wolff wrote: module-set repository kde-projects branch qt5 use-modules polkit-qt-1 cmake-options -DCMAKE_BUILD_TYPE:STRING=debug end module-set Considering that

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-06 Thread Luigi Toscano
On March 5, 2014, 3:36 p.m., Burkhard Lück wrote: src/meinproc.cpp, lines 170-179 https://git.reviewboard.kde.org/r/116604/diff/1/?file=252003#file252003line170 How does this affect this code in KHelpcenter: kde-runtime/khelpcenter/glossary.cpp:149:KProcess

Re: Review Request 116639: Do not read LOCATION property of desktoptojson

2014-03-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116639/#review52312 --- Ship it! Ship It! - Alex Merry On March 6, 2014, 3:42

Re: Review Request 116025: Add documentation about writing find modules

2014-03-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated March 6, 2014, 10:56 p.m.) Review request for Build System,

Jenkins build became unstable: ktexteditor_master_qt5 #236

2014-03-06 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/236/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel