Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff

2014-03-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Jenkins build is back to normal : kinit_master_qt5 #43

2014-03-21 Thread KDE CI System
See http://build.kde.org/job/kinit_master_qt5/43/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 21, 2014, 10:02 a.m.) Status -- This change has been

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 21, 2014, 10:02 a.m.) Status -- This change has been

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/#review53632 --- This review has been submitted with commit

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 21, 2014, 10:02 a.m.) Status -- This change has been

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/#review53631 --- This review has been submitted with commit

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/#review53633 --- This review has been submitted with commit

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

2014-03-21 Thread Ben Cooksley
On Fri, Mar 21, 2014 at 12:45 PM, David Faure fa...@kde.org wrote: On Wednesday 05 March 2014 10:44:24 Kevin Ottens wrote: Hello, On Tuesday 04 March 2014 22:54:42 David Faure wrote: On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote: It wasn't that transparent at all - a number of

Re: Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)

2014-03-21 Thread Martin Klapetek
On Wed, Mar 19, 2014 at 8:26 PM, Aleix Pol aleix...@kde.org wrote: Hi Dominik, I've been looking though it and it seems like in this case we should be showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on the result of options()-testOption(QFileDialogOptions::ShowDirsOnly).

Re: Re: Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)

2014-03-21 Thread Dominik Haumann
On Friday, March 21, 2014 12:05:51 Martin Klapetek wrote: On Wed, Mar 19, 2014 at 8:26 PM, Aleix Pol aleix...@kde.org wrote: Hi Dominik, I've been looking though it and it seems like in this case we should be showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on the

Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 21, 2014, 3:41 p.m.) Review request for KDE Frameworks

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks

Re: Review Request 116935: Remove use of KLibrary in KLauncher

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 21, 2014, 3:49 p.m.) Review request for KDE Frameworks

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 21, 2014, 3:50 p.m.) Review request for KDE Frameworks

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-21 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/#review53702 --- this seems to broke kded modules loading here: Cannot load

Review Request 116955: Remove KDE 4 refs from Doxyfile.global

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116955/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository:

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-21 Thread Hrvoje Senjan
On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: this seems to broke kded modules loading here: Cannot load library /usr/lib64/libkdeinit5_kio_file: (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No such file or directory) err, s/kded modules/kio plugins -

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-21 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 21, 2014, 9:26 a.m.) Review request for KDE Frameworks.

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-21 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53705 --- Ship it! Looks reasonable to me, thanks! - Frank

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #168

2014-03-21 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/168/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream

2014-03-21 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream

2014-03-21 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- (Updated March 21, 2014, 5:05 p.m.) Review request for KDE Frameworks.

Review Request 116958: Update comment referencing fake MIME types

2014-03-21 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/ --- Review request for KDE Frameworks. Repository: kservice Description

Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- Review request for KDE Frameworks. Repository: kcmutils Description

Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53708 --- Ship it! Ship It! - David Gil Oliva On March 21, 2014,

Review Request 116961: Replace fake MIME type

2014-03-21 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Review Request 116962: Clean up KDE4 references in kconfig

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53710 --- This review has been submitted with commit

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- (Updated March 21, 2014, 6:26 p.m.) Status -- This change has been

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53724 --- Hi! You didn't submit the modification of kcompletionbox.

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53725 --- This review has been submitted with commit

Re: Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116939/#review53727 --- This review has been submitted with commit

Re: Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116939/ --- (Updated March 21, 2014, 9:19 p.m.) Status -- This change has been

Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 116967: Fix doc in KUrlPixmapProvider

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons

Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 116970: Remove wish in KComboBox

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- Review request for KDE Frameworks. Repository: kcompletion Description