---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120720/
---
(Updated Oct. 28, 2014, 7:37 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/
---
(Updated Oct. 28, 2014, 1:20 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120794/#review69243
---
src/application.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/#review69246
---
src/widgets/executablefileopendialog.cpp
See http://build.kde.org/job/kservice_master_qt5/195/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Oct. 28, 2014, 3:35 p.m., David Faure wrote:
src/widgets/krun.cpp, line 978
https://git.reviewboard.kde.org/r/120666/diff/3/?file=322409#file322409line978
This should use the 4 args connect, in case the KRun gets deleted
before the dialog.
i.e. insert ,this as the
On Oct. 28, 2014, 10:05 a.m., David Faure wrote:
src/widgets/krun.cpp, line 978
https://git.reviewboard.kde.org/r/120666/diff/3/?file=322409#file322409line978
This should use the 4 args connect, in case the KRun gets deleted
before the dialog.
i.e. insert ,this as
On Oct. 28, 2014, 3:35 p.m., David Faure wrote:
src/widgets/executablefileopendialog.cpp, line 64
https://git.reviewboard.kde.org/r/120666/diff/3/?file=322407#file322407line64
where is this slot used?
Nowhere. The file was copy-pasted from the other patch
- Arjun
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/
---
(Updated Oct. 28, 2014, 5:13 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/#review69260
---
Ship it!
Just one last thing, then push.
On Oct. 28, 2014, 9:32 a.m., David Faure wrote:
src/application.cpp, line 785
https://git.reviewboard.kde.org/r/120794/diff/2/?file=322403#file322403line785
It's a bit confusing because QCLP::process() is not the same, and also
because of the other processCmdLine method here.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/
---
(Updated Oct. 28, 2014, 1:37 p.m.)
Status
--
This change has been
On Oct. 28, 2014, 9:32 a.m., David Faure wrote:
src/application.cpp, line 789
https://git.reviewboard.kde.org/r/120794/diff/2/?file=322403#file322403line789
Note that you might want to use the cwd in order to resolve urls with
it, so that rekonq localfile.html works.
This
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120794/
---
(Updated Oct. 28, 2014, 2 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120854/
---
Review request for KDE Frameworks.
Bugs: 340238
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120854/#review69303
---
Should maybe be delay 0?
Either way, +1.
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120794/#review69317
---
src/application.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120794/#review69318
---
src/application.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120833/#review69357
---
This should be done in Qt, IMHO. The docu (which I added in
On Oct. 28, 2014, 9:59 p.m., David Faure wrote:
This should be done in Qt, IMHO. The docu (which I added in 418890e07) says
We recommend omitting the file's suffix in the file name without
specifying that this would only work for relative paths.
I can look into adding that somewhen,
On Okt. 28, 2014, 10:59 nachm., David Faure wrote:
This should be done in Qt, IMHO. The docu (which I added in 418890e07) says
We recommend omitting the file's suffix in the file name without
specifying that this would only work for relative paths.
David Faure wrote:
I can look
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120813/
---
(Updated Oct. 28, 2014, 11:14 p.m.)
Status
--
This change has been
Heya,
I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is
there some?
http://lxr.kde.org/ident?v=kf5-qt5_i=isBinaryData_remember=1 shows exactly
two users of this function.
Worth considering upstreaming to Qt?
--
Kevin Funk | kf...@kde.org | http://kfunk.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/
---
Review request for KDE Frameworks, kdewin and Plasma.
Repository:
24 matches
Mail list logo