Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext - HTML conversion

2014-11-12 Thread Aleix Pol Gonzalez
On Nov. 11, 2014, 12:22 p.m., Laurent Montel wrote: src/lib/text/ktexttohtml.cpp, line 380 https://git.reviewboard.kde.org/r/121094/diff/1/?file=327569#file327569line380 same here There's no semantic difference between x++ and ++x here, I don't see the point of requesting this

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-12 Thread Aleix Pol Gonzalez
On Nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote: I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put it in

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-12 Thread Albert Astals Cid
On nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote: I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put it in

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-12 Thread Pedro Francisco
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/#review70280 --- Ship it! Ship It! - Pedro Francisco On Nov. 8, 2014,

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

2014-11-12 Thread Michael Hansen
Ping? On Thu, Oct 23, 2014 at 10:09 AM, Michael Hansen zrax0...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ Review request for KDE Frameworks and Christoph Cullmann. By Michael Hansen. *Repository: *

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

2014-11-12 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated nov. 12, 2014, 7:06 p.m.) Review request for Kate, KDE

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

2014-11-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/#review70293 --- Ship it! I think the changes makes sense and the code looks

Review Request 121109: Use CMAKE_INSTALL_FULL_PLUGINDIR

2014-11-12 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121109/ --- Review request for KDE Frameworks and Ivan Čukić. Bugs: 340900

Re: Review Request 121109: Use CMAKE_INSTALL_FULL_PLUGINDIR

2014-11-12 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121109/#review70295 --- Ship it! Thanks! - Ivan Čukić On Nov. 12, 2014, 7:43

Re: Review Request 121109: Use CMAKE_INSTALL_FULL_PLUGINDIR

2014-11-12 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121109/ --- (Updated Nov. 12, 2014, 8:11 p.m.) Status -- This change has been

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-12 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/#review70302 --- Since this seems quite easy to test, I would like automated

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-12 Thread David Faure
On nov. 11, 2014, 2:39 après-midi, Albert Astals Cid wrote: I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put

Re: Review Request 119567: Also find catalog files that are symlinks

2014-11-12 Thread Luigi Toscano
On Aug. 2, 2014, 1:25 a.m., Luigi Toscano wrote: src/xslt.cpp, line 426 https://git.reviewboard.kde.org/r/119567/diff/1/?file=294860#file294860line426 Uhm, but that's strange. Just to be sure, do I understand it correctly that every file in customization is sym-linked? O.o

Re: Split kde-baseapps?

2014-11-12 Thread David Narvaez
On Mon, Nov 10, 2014 at 4:46 PM, David Faure fa...@kde.org wrote: If it's useful to share it, let's share it, I have no objection to that. How should this be done? Can I just copy things around and post a RR or should be this moved around by one of our git curators to preserve history? David E.

Re: Review Request 121090: Move kio-mtp to kio-extras

2014-11-12 Thread Aleix Pol Gonzalez
On Nov. 12, 2014, 10:04 p.m., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Well, there's important kio's as well in kio-extras. Question is, is it useful outside the

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-12 Thread Aleix Pol Gonzalez
On Nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote: I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put it in