Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-19 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/ --- (Updated Nov. 19, 2014, 8:21 a.m.) Status -- This change has been

Re: Review Request 121090: Move kio-mtp to kio-extras

2014-11-19 Thread Jan Grulich
On Lis. 12, 2014, 10:04 odp., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Aleix Pol Gonzalez wrote: Well, there's important kio's as well in kio-extras. Question is,

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-19 Thread Jan Grulich
On Thursday 13 of November 2014 16:39 Albert Astals Cid wrote: El Dijous, 13 de novembre de 2014, a les 16:27:20, Albert Astals Cid va escriure: El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review:

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 19, 2014, 10:39 a.m.) Status -- This change has been

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-19 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70643 --- src/kcodecs.h

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-19 Thread Daniel Vrátil
On Nov. 18, 2014, 10:58 p.m., David Faure wrote: src/kcodecs.h, line 786 https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327084#file327084line786 should be private, maybe? or is it used by subclasses? The d pointers are actually accessed by implementations, so it has to be

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-19 Thread Daniel Vrátil
On Nov. 19, 2014, 1:45 p.m., Daniel Vrátil wrote: src/kcodecs.h, line 786 https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327084#file327084line786 The d pointers are actually accessed by implementations, so it has to be protected. Blah, this was supposed to be a comment

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-19 Thread Daniel Vrátil
On Nov. 18, 2014, 10:58 p.m., David Faure wrote: src/kcodecs.cpp, line 113 https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327085#file327085line113 Sounds like we should at least add a TODO KF6: remove bool insertLFs, if it's useless? The alternative is to do

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

2014-11-19 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 19, 2014, 1:15 p.m.) Status -- This change has been

Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

2014-11-19 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121175/ --- Review request for KDE Frameworks and David Faure. Repository: kcodecs

OSX/CI: lokalize fails to build on branch frameworks

2014-11-19 Thread Marko Käning
Hi, I was giving lokalize a try on OSX/CI, but it failed, as it couldn’t locate hunspell properly, which is installed via MacPorts on the OSX/CI system below prefix /opt/local: --- $ port installed hunspell* The following ports are currently installed: hunspell @1.3.3_0 (active)

Re: Review Request 121178: Fix build of kdelibs4support on OSX/CI

2014-11-19 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121178/ --- (Updated nov. 19, 2014, 9:29 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kdelibs4support_master_qt5 #301

2014-11-19 Thread KDE CI System
See http://build.kde.org/job/kdelibs4support_master_qt5/301/ -- [...truncated 1415 lines...] ^ Scanning dependencies of target kglobalstatictest [ 77%] Building CXX object autotests/CMakeFiles/kglobalstatictest.dir/kglobalstatictest.cpp.o

Build failed in Jenkins: kcodecs_master_qt5 #71

2014-11-19 Thread KDE CI System
See http://build.kde.org/job/kcodecs_master_qt5/71/changes Changes: [Daniel Vrátil] Fix linker error when building against KCodecs -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Jenkins build is back to normal : kcodecs_master_qt5 #72

2014-11-19 Thread KDE CI System
See http://build.kde.org/job/kcodecs_master_qt5/72/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdelibs4support_master_qt5 #302

2014-11-19 Thread KDE CI System
See http://build.kde.org/job/kdelibs4support_master_qt5/302/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121178: Fix build of kdelibs4support on OSX/CI

2014-11-19 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121178/ --- (Updated Nov. 19, 2014, 10:54 p.m.) Status -- This change has been

Re: Review Request 121181: kcmshell: return -1 if module wasn't found

2014-11-19 Thread Teemu Rytilahti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/ --- (Updated Nov. 19, 2014, 11:42 p.m.) Review request for KDE Frameworks.

Review Request 121181: kcmshell: return -1 if module wasn't found

2014-11-19 Thread Teemu Rytilahti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/ --- Review request for KDE Frameworks. Repository: kde-cli-tools

Re: Review Request 121181: kcmshell: return -1 if module wasn't found

2014-11-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/#review70672 --- +1 looks good to me. - Aleix Pol Gonzalez On Nov. 19,

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/ --- (Updated Nov. 20, 2014, 3:29 a.m.) Status -- This change has been

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- (Updated Nov. 20, 2014, 3:29 a.m.) Status -- This change has been

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #199

2014-11-19 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_frameworks_qt5/199/changes Changes: [andriusmao] Do not require KF5::Su on Windows. [andriusmao] Fix Exports. -- [...truncated 1578 lines...] ^

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70678 --- This breaks compilation on Linux (was this tested?) and on