Re: Baloo Framework - License Exception

2015-01-05 Thread Kevin Ottens
Hello, I've been summoned by CCing, loose all hope! :-) On Sunday 04 January 2015 11:23:49 David Faure wrote: On Tuesday 16 December 2014 14:02:18 Sebastian Kügler wrote: - If it's effectively GPL-licensed, it should not be a proper Framework I would like to challenge this reasoning. It

Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs:

Re: Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Gen. 5, 2015, 9:41 a.m.) Review request for KDE Frameworks,

Re: Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Gen. 5, 2015, 9:41 a.m.) Review request for KDE Frameworks and

Re: Split kde-baseapps?

2015-01-05 Thread David Faure
On Wednesday 12 November 2014 18:26:22 David Narvaez wrote: On Mon, Nov 10, 2014 at 4:46 PM, David Faure fa...@kde.org wrote: If it's useful to share it, let's share it, I have no objection to that. How should this be done? Can I just copy things around and post a RR or should be this moved

Re: Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Jan. 5, 2015, 12:20 p.m.) Status -- This change has been

Re: Baloo Framework - License Exception

2015-01-05 Thread Sebastian Kügler
Hi, On Sunday, January 04, 2015 11:23:49 David Faure wrote: On Tuesday 16 December 2014 14:02:18 Sebastian Kügler wrote: - If it's effectively GPL-licensed, it should not be a proper Framework I would like to challenge this reasoning. It seems to me that the premise is: * we need baloo

Re: Baloo Framework - License Exception

2015-01-05 Thread Vishesh Handa
On Mon, Jan 5, 2015 at 1:58 PM, Sebastian Kügler se...@kde.org wrote: Are we going to shoot ourselves in the foot (= making our lives more complicated, by having a dependency that works differently from the other dependencies and has to be released separately) just so that we can say all

Re: Baloo Framework - License Exception

2015-01-05 Thread David Edmundson
On Mon, Jan 5, 2015 at 3:04 PM, Sebastian Kügler se...@kde.org wrote: On Monday, January 05, 2015 14:32:32 Vishesh Handa wrote: On Mon, Jan 5, 2015 at 1:58 PM, Sebastian Kügler se...@kde.org wrote: Are we going to shoot ourselves in the foot (= making our lives more complicated, by

Re: Baloo Framework - License Exception

2015-01-05 Thread Sebastian Kügler
On Monday, January 05, 2015 19:04:43 David Faure wrote: On Monday 05 January 2015 16:11:21 David Edmundson wrote: Maybe we could all agree to let Kevin Krammer (as I understand it, the current head of frameworks) to make a tough executive decision based on the thoughts people have had

Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-01-05 Thread David Faure
On Jan. 5, 2015, 9:37 p.m., David Faure wrote: Ah cool, I didn't know the Qt5 implementation of QFSW solved this. Nice. Ralf Habacker wrote: The motivation for KFileSystemWatcher is the following limitation: * the maximum number of object handles is MAXIMUM_WAIT_OBJECTS

Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-01-05 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121861/ --- (Updated Jan. 5, 2015, 10:18 p.m.) Status -- This change has been

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Matthew Dawson
On Jan. 4, 2015, 12:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Plasma NM 5.1.2.1

2015-01-05 Thread Jonathan Riddell
plasma-nm has gained an extra release, 5.1.2.1, which updates it to use networkmanager-qt (the new name of libnm-qt) 5.6.0 which is due to be released with the KDE Frameworks 5 release tomorrow. It will not compile with libnm-qt as released with Plasma 5.1.x, just keep using plasma-nm 5.1.2 is

Review Request 121864: Get rid of KDBusMenuExporter and use DBusMenuExporter directly

2015-01-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121864/ --- Review request for KDE Frameworks. Repository: knotifications

Review Request 121865: Fix cross compile error using Windows.h instead correctly windows.h.

2015-01-05 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121865/ --- Review request for KDE Frameworks. Repository: karchive Description

Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-01-05 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121861/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Matthew Dawson
On Jan. 4, 2015, 12:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Albert Astals Cid
On gen. 4, 2015, 5:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121865: Fix cross compile error using Windows.h instead correctly windows.h.

2015-01-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121865/#review73199 --- Ship it! the commit log is a bit confusing though. Did you

Review Request 121862: Move the kglobalaccel runtime into the framework

2015-01-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/ --- Review request for KDE Frameworks, David Faure, Martin Gräßlin, and Hrvoje

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

2015-01-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/#review73173 --- This won't be in KF 5.6, which is already tagged, while this

Re: Split kde-baseapps?

2015-01-05 Thread Martin Klapetek
On Mon, Jan 5, 2015 at 9:27 AM, David Faure fa...@kde.org wrote: On Wednesday 12 November 2014 18:26:22 David Narvaez wrote: On Mon, Nov 10, 2014 at 4:46 PM, David Faure fa...@kde.org wrote: If it's useful to share it, let's share it, I have no objection to that. How should this be