Build failed in Jenkins: kde-baseapps_master_qt5 #208
See http://build.kde.org/job/kde-baseapps_master_qt5/208/changes Changes: [emmanuelpescosta099] Port ConfigurePreviewPluginDialog away from KLibrary, KIO::NetAccess::del and ThumbCreatorV2 [emmanuelpescosta099] Removed old (= 4.6) settings upgrading code (jpegrotatedthumbnail to jpegthumbnail) from PreviewsSettingsPage -- [...truncated 2893 lines...] ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp: In member function ‘void ViewMgrTest::testSaveProfile()’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:704:19: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] const KUrl url(data:text/html, pHello World/p); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:708:20: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] const KUrl url2(data:text/html, pview2/p); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:710:17: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:710:60: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp: In member function ‘void ViewMgrTest::testCloseOtherTabs()’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:762:17: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:762:60: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp: In member function ‘void ViewMgrTest::testCloseTabsFast()’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:792:17: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:792:60: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp: In member function ‘void ViewMgrTest::moveTabLeft()’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:894:17: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqviewmgrtest.cpp:894:60: warning: ‘KTabWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktabwidget.h:44) [-Wdeprecated-declarations] KTabWidget* tabWidget = mainWindow.findChildKTabWidget*();
Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74671 --- The overall idea is sound. Just a few issues: autotests/kconfig_in_global_object.cpp https://git.reviewboard.kde.org/r/122232/#comment51750 This doesn't actually trigger anything when run without the fix below. Since a name is provided in initConfig, it never tries to fetch the global name and thus doesn't test the issue. I think these two files should be the exact same, except for testing KSharedConfig vs KConfig. autotests/ksharedconfig_in_global_object.cpp https://git.reviewboard.kde.org/r/122232/#comment51751 Just before this, could you stick a: qputenv(QT_FATAL_WARNINGS, 1); That way if a warning is printed the test will fail. Otherwise this change might be removed with tests still passing. src/core/kconfig.cpp https://git.reviewboard.kde.org/r/122232/#comment51752 Reading the Qt documentation, I think its possible that appArgs[0] isn't the application name on Windows, and thus appArgs may stay empty. Maybe add another conditional checking its empty in this if statement, and if it still is add some random value? - Matthew Dawson On Jan. 23, 2015, 5:39 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- (Updated Jan. 23, 2015, 5:39 p.m.) Review request for KDE Frameworks, Albert Astals Cid and Matthew Dawson. Repository: kconfig Description --- kconfig_in_global_object.cpp comes from kdelibs4support (after porting to Q_GLOBAL_STATIC) ksharedconfig_in_global_object.cpp is new (but works with kdelibs4) and reproduces Albert's KgDifficulty testcase. Diffs - autotests/CMakeLists.txt b91f754b705fc87bb8b729bea72fbb5f7d427ace autotests/kconfig_in_global_object.cpp PRE-CREATION autotests/ksharedconfig_in_global_object.cpp PRE-CREATION src/core/kconfig.cpp 782e9714521234a3e3d8f3a788967e5c9a40f38a Diff: https://git.reviewboard.kde.org/r/122232/diff/ Testing --- Both tests pass and the QCoreApplication::arguments warning (because called after qApp is destroyed) is gone. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/ --- (Updated Jan. 24, 2015, 12:02 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Kevin Ottens. Repository: kdbusaddons Description --- This is what the DBus message filter uses in order to find out which module is being called, in order to auto-load it. Diffs - src/kdedmodule.h 706529a1639b17118abfd80a02b310dd2acbc00d src/kdedmodule.cpp 54611c52775803ac734b52a53d79d2c762315112 Diff: https://git.reviewboard.kde.org/r/122178/diff/ Testing --- autoloading modules in kiod and kded works Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121448: Introduce ECMAddAppIcon.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Jan. 24, 2015, 1:27 nachm.) Status -- This change has been discarded. Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet. Repository: extra-cmake-modules Description --- This module, which has been migrated from the related KDE4 macto kde4_app_app_icon, supports platform specific application icon for Windows and Mac OSX. On Windows this function depends on the external tool png2ico, which is provided by the kdewin-tools binary package. Sources are available at https://projects.kde.org/projects/kdesupport/kdewin. Diffs - modules/ECMAddAppIcon.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121448/diff/ Testing --- File Attachments ECMAddAppIcon.cmake https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake ECMAddAppIcon.cmake https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8b3e226f-a70b-4998-983a-813730a436bf__ECMAddAppIcon.cmake ECMAddAppIcon.cmake https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8433995f-b88f-426d-af54-46aba635ae1e__ECMAddAppIcon.cmake Thanks, Ralf Habacker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/#review74655 --- Ship it! Ship It! - Alex Merry On Jan. 21, 2015, 9:03 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/ --- (Updated Jan. 21, 2015, 9:03 a.m.) Review request for KDE Frameworks and Kevin Ottens. Repository: kdbusaddons Description --- This is what the DBus message filter uses in order to find out which module is being called, in order to auto-load it. Diffs - src/kdedmodule.h 706529a1639b17118abfd80a02b310dd2acbc00d src/kdedmodule.cpp 54611c52775803ac734b52a53d79d2c762315112 Diff: https://git.reviewboard.kde.org/r/122178/diff/ Testing --- autoloading modules in kiod and kded works Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122235: --version: Change KDE Development Platform to KDE Frameworks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122235/ --- Review request for KDE Frameworks and David Faure. Repository: kdelibs4support Description --- As suggested by dfaure Diffs - src/kdecore/kcmdlineargs.cpp e1a5013 Diff: https://git.reviewboard.kde.org/r/122235/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74666 --- Makes sense to me, need someone else to approve though, not a kconfig expert myself - Albert Astals Cid On gen. 23, 2015, 10:39 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- (Updated gen. 23, 2015, 10:39 p.m.) Review request for KDE Frameworks, Albert Astals Cid and Matthew Dawson. Repository: kconfig Description --- kconfig_in_global_object.cpp comes from kdelibs4support (after porting to Q_GLOBAL_STATIC) ksharedconfig_in_global_object.cpp is new (but works with kdelibs4) and reproduces Albert's KgDifficulty testcase. Diffs - autotests/CMakeLists.txt b91f754b705fc87bb8b729bea72fbb5f7d427ace autotests/kconfig_in_global_object.cpp PRE-CREATION autotests/ksharedconfig_in_global_object.cpp PRE-CREATION src/core/kconfig.cpp 782e9714521234a3e3d8f3a788967e5c9a40f38a Diff: https://git.reviewboard.kde.org/r/122232/diff/ Testing --- Both tests pass and the QCoreApplication::arguments warning (because called after qApp is destroyed) is gone. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122235: --version: Change KDE Development Platform to KDE Frameworks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122235/#review74668 --- Ship it! I agree :-) - David Faure On Jan. 24, 2015, 2:36 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122235/ --- (Updated Jan. 24, 2015, 2:36 p.m.) Review request for KDE Frameworks and David Faure. Repository: kdelibs4support Description --- As suggested by dfaure Diffs - src/kdecore/kcmdlineargs.cpp e1a5013 Diff: https://git.reviewboard.kde.org/r/122235/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
