---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123669/#review80013
---
Seems like this is duplicated in a few places already so I
On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote:
src/plasma/pluginloader.cpp, line 892
https://git.reviewboard.kde.org/r/123626/diff/4/?file=366900#file366900line892
Can this lead to containmentactions being listed twice? (I haven't seen
it in the UI, but seems plausible as a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review80025
---
solved issues, still there the magic self() call, for that,
On May 7, 2015, 8:48 p.m., David Rosca wrote:
Sorry, didn't know of the bug. Should I discard this rr?
Why? What you propose here was discussed as one possible option.
- Christoph
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123493/
---
(Updated May 7, 2015, 9:20 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123679/
---
Review request for KDE Frameworks and Stephen Kelly.
Repository:
On May 7, 2015, 11:59 a.m., Sebastian Kügler wrote:
src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml, line
197
https://git.reviewboard.kde.org/r/123626/diff/5/?file=367344#file367344line197
This line may have slipped in?
ouch, i pushed a commit in the wrong
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123492/
---
(Updated May 7, 2015, 9:18 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123677/
---
Review request for KDE Frameworks.
Repository: ktexteditor
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123677/
---
(Updated May 7, 2015, 8:45 p.m.)
Review request for Kate and KDE
On May 7, 2015, 8:48 p.m., David Rosca wrote:
Sorry, didn't know of the bug. Should I discard this rr?
Christoph Feck wrote:
Why? What you propose here was discussed as one possible option.
Yes, but from the bug discussion it seems reverting those commits is not
something that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123677/#review80059
---
Sorry, didn't know of the bug. Should I discard this rr?
-
Hi,
As with some other bits of knowledge during porting today I just share this one:
https://community.kde.org/index.php?title=Calligra/Building/3diff=42353oldid=42349
When you use Qt4/KF5, debugfull is dead [1] so you'd be surprised
debugging isn't working for you.
We don't have any precise
On May 7, 2015, 7:24 a.m., Alex Richardson wrote:
Seems like this is duplicated in a few places already so I agree we should
add it. But won't most users of the API want only a single plugin returned?
Maybe also add a function `KPluginMetaData
KPluginLoader::findPluginById(const
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---
(Updated May 7, 2015, 2:31 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review80030
---
Ship it!
Looks good.
On May 6, 2015, 11:24 p.m., David Edmundson wrote:
autotests/kpluginloadertest.cpp, line 357
https://git.reviewboard.kde.org/r/123669/diff/1/?file=367268#file367268line357
not that it really matters, but invalid is spelt wrong.
Double the invalidity.
it says invalid id,
On May 7, 2015, 7:24 a.m., Alex Richardson wrote:
Seems like this is duplicated in a few places already so I agree we should
add it. But won't most users of the API want only a single plugin returned?
Maybe also add a function `KPluginMetaData
KPluginLoader::findPluginById(const
18 matches
Mail list logo
