Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124101/ --- Review request for KDE Frameworks. Repository: kdelibs4support Description --- When porting code to KF5 while using kdelibs4support, `kDebug() someKDateTimeObject;` will not build. Because for some undocumented reason (at least in current repo, did not investigate further) `QDebug operator(QDebug s, const KDateTime time);` had been disabled. I could not see any problems after reenabling it again. So would propose to do it for everyone, to make kdelibs4support a tiny bit more source-compatible for kdelibs4-using code :) Diffs - src/kdecore/kdebug.h ff7607f src/kdecore/kdebug.cpp 2705ec9 Diff: https://git.reviewboard.kde.org/r/124101/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
On June 13, 2015, 7:28 p.m., David Faure wrote:
startTimer is called many times so doing the connect every time is wrong,
and the connect is already done before, so I don't understand this patch.
What problem is it supposed to fix?
I was having an issue with Konsole on Plasma 5 (Kubuntu 15.04). When opening
links in Konsole, Konsole would freeze and the link wouldn't open. In Konsole
on Plasma 5, type out a link (like https://www.kde.org;), right click on the
link and click Open Link. Konsole will freeze. This was reproducible for me,
and--although I didn't see any other repots on the issue--I decided to
investigate it and fix it. Adding this line resolved the issue.
The initial call comes from the konsole repository in the slot
UrlFilter::HotSpot::activate. actiate() then calls new KRun(QUrl(url),
activeWindow);::
void UrlFilter::HotSpot::activate(QObject* object)
{
qDebug() Opening URL object;
QString url = capturedTexts().first();
const UrlType kind = urlType();
const QString actionName = object ? object-objectName() : QString();
if (actionName == copy-action) {
QApplication::clipboard()-setText(url);
return;
}
if (!object || actionName == open-action) {
if (kind == StandardUrl) {
// if the URL path does not include the protocol ( eg.
www.kde.org ) then
// prepend http:// ( eg. www.kde.org -- http://www.kde.org;
)
if (!url.contains(://)) {
url.prepend(http://;);
}
} else if (kind == Email) {
url.prepend(mailto:;);
}
QWidget *activeWindow = QApplication::activeWindow();
qDebug() Launching KRun with url , activeWindow;
new KRun(QUrl(url), activeWindow);
}
}
Or is the issue really in konsole? Should Konsole create a new instance of
``KRun()`` and then call ``k-init()``?
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/#review81450
---
On June 12, 2015, 8:27 p.m., Jordan He wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/
---
(Updated June 12, 2015, 8:27 p.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
Connected timeout before timer start.
Diffs
-
src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825
Diff: https://git.reviewboard.kde.org/r/124089/diff/
Testing
---
Thanks,
Jordan He
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124089: Connected timeout before timer start.
On June 13, 2015, 7:28 p.m., David Faure wrote:
startTimer is called many times so doing the connect every time is wrong,
and the connect is already done before, so I don't understand this patch.
What problem is it supposed to fix?
Jordan He wrote:
I was having an issue with Konsole on Plasma 5 (Kubuntu 15.04). When
opening links in Konsole, Konsole would freeze and the link wouldn't open. In
Konsole on Plasma 5, type out a link (like https://www.kde.org;), right
click on the link and click Open Link. Konsole will freeze. This was
reproducible for me, and--although I didn't see any other repots on the
issue--I decided to investigate it and fix it. Adding this line resolved the
issue.
The initial call comes from the konsole repository in the slot
UrlFilter::HotSpot::activate. actiate() then calls new KRun(QUrl(url),
activeWindow);::
void UrlFilter::HotSpot::activate(QObject* object)
{
qDebug() Opening URL object;
QString url = capturedTexts().first();
const UrlType kind = urlType();
const QString actionName = object ? object-objectName() :
QString();
if (actionName == copy-action) {
QApplication::clipboard()-setText(url);
return;
}
if (!object || actionName == open-action) {
if (kind == StandardUrl) {
// if the URL path does not include the protocol ( eg.
www.kde.org ) then
// prepend http:// ( eg. www.kde.org --
http://www.kde.org; )
if (!url.contains(://)) {
url.prepend(http://;);
}
} else if (kind == Email) {
url.prepend(mailto:;);
}
QWidget *activeWindow = QApplication::activeWindow();
qDebug() Launching KRun with url ,
activeWindow;
new KRun(QUrl(url), activeWindow);
}
}
Or is the issue really in konsole? Should Konsole create a new instance
of ``KRun()`` and then call ``k-init()``?
new KRun is the correct way to use KRun with a URL.
(The string concatenation in this code, to make up the URL, will break with
special chars and should use KUriFilters, but that's orthogonal).
The KRun constructor calls d-init(), which starts m_timer and connects it to
slotTimeout, which the first time, calls KRun::init().
So if this doesn't work correctly in konsole, it must mean that konsole isn't
going back to the event loop (so that initial timer can't run). Attach gdb to
it to confirm/deny this hypothesis. Otherwise add debug statements within KRun
to confirm/deny the various calls I describe above.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/#review81450
---
On June 12, 2015, 8:27 p.m., Jordan He wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/
---
(Updated June 12, 2015, 8:27 p.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
Connected timeout before timer start.
Diffs
-
src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825
Diff: https://git.reviewboard.kde.org/r/124089/diff/
Testing
---
Thanks,
Jordan He
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81501 --- +1 on the idea from me. I don't know CMake well, so I'd prefer to have a CMake guru +1 this RR. I do have a note below, but it isn't a blocker. src/kconfig_compiler/CMakeLists.txt (line 16) https://git.reviewboard.kde.org/r/124104/#comment55869 Does this mean a cross-compiled KConfig won't be built right for development on the target? If this happens regardless, is the cross compiling still possible? My CMake foo is weak, so if no one knows an alternative, I'm fine. I'd just prefer KConfig to work on the target for development too. - Matthew Dawson On June 15, 2015, 1:59 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- (Updated June 15, 2015, 1:59 p.m.) Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter. Repository: kconfig Description --- Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly. Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=... Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks. Diffs - CMakeLists.txt f510e3e KF5ConfigConfig.cmake.in b4e5f56 src/kconfig_compiler/CMakeLists.txt ec4a733 Diff: https://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources
On June 16, 2015, 5:12 a.m., Matthew Dawson wrote: src/kconfig_compiler/CMakeLists.txt, line 16 https://git.reviewboard.kde.org/r/124104/diff/1/?file=380232#file380232line16 Does this mean a cross-compiled KConfig won't be built right for development on the target? If this happens regardless, is the cross compiling still possible? My CMake foo is weak, so if no one knows an alternative, I'm fine. I'd just prefer KConfig to work on the target for development too. Well, the idea is that if you're cross-compiling, the generated executable won't work on the host architecture, by definition. In case it's needed, we could import an actual KF5ConfigCompilerConfig.cmake from the host architecture. In this case it doesn't really make sense though. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81501 --- On June 15, 2015, 7:59 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- (Updated June 15, 2015, 7:59 p.m.) Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter. Repository: kconfig Description --- Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly. Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=... Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks. Diffs - CMakeLists.txt f510e3e KF5ConfigConfig.cmake.in b4e5f56 src/kconfig_compiler/CMakeLists.txt ec4a733 Diff: https://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81500 --- +1 - David Edmundson On June 15, 2015, 5:59 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- (Updated June 15, 2015, 5:59 p.m.) Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter. Repository: kconfig Description --- Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly. Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=... Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks. Diffs - CMakeLists.txt f510e3e KF5ConfigConfig.cmake.in b4e5f56 src/kconfig_compiler/CMakeLists.txt ec4a733 Diff: https://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!
Check console output at https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 8 - Fixed!
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124104: Make it possible to use kconfig_compiler from different sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter. Repository: kconfig Description --- Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly. Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=... Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks. Diffs - CMakeLists.txt f510e3e KF5ConfigConfig.cmake.in b4e5f56 src/kconfig_compiler/CMakeLists.txt ec4a733 Diff: https://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 7 - Failure!
Check console output at https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master stable-kf5-qt5 » OSX,clang - Build # 7 - Failure!
Check console output at https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/7/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 7 - Failure!
Check console output at https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124105: Adhere a bit better to the spec
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/ --- Review request for KDE Frameworks, David Faure and Martin Klapetek. Repository: kiconthemes Description --- According to table 2 in the icon theme spec, the Context per directory key is optional, and the Type key defaults to Threshold if not specified. Let's make the code do the same. Diffs - src/kicontheme.cpp 4f0e522 Diff: https://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Custom translated fields
Hi
Summing up,
As I need get things done, I'm looking for someone to help me with
createdesktopcontext.pl
- basically change from
my $regexp =
qr{^(Name|Comment|Language|Keywords|X-KDE-Keywords|About|Description|GenericName|Query|ExtraNames|X-KDE-Submenu)=(.+)};
-- to recognize extra fields of type localestring [1].
Magic # translate comment is one solution but another could be that
for field Foo I am adding:
Foo=Bar
Foo[x-test]=xxBarxx
And in final .desktop file it's rather clean, no extra comments appear.
[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html
On 11 June 2015 at 15:43, Burkhard Lück lu...@hube-lueck.de wrote:
Am Donnerstag, 11. Juni 2015, 09:28:40 schrieb Jaroslaw Staniek:
Thanks, please let me understand; first - regarding KPluginMetaData:
Why is a hint needed there if KPluginMetaData::readTranslatedString()
cust constructs a magic key with a [lang] sufffix?
You are right, no hint needed.
--
Burkhard Lück
--
regards, Jaroslaw Staniek
KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master stable-kf5-qt5 » OSX,clang - Build # 9 - Fixed!
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Equivalent of KDE::version*()?
Hi, One would need a need runtime version information of particular kf5 libraries -- in addition to version with which the software has been built. It seems that mostly Plasma and KActivities have equivalent of runtime version information. I am not looking build-time *_version.h files generated (with *_VERSION_* macros) but something like plasma-framework/src/plasma/version.h. Attica is a good exception here, I cannot spot anything else. PS: Maybe the code can be generated? -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124105: Adhere a bit better to the spec
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review81498 --- src/kicontheme.cpp (line 664) https://git.reviewboard.kde.org/r/124105/#comment55868 Space after , - Christoph Feck On June 15, 2015, 7:30 p.m., Sune Vuorela wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/ --- (Updated June 15, 2015, 7:30 p.m.) Review request for KDE Frameworks, David Faure and Martin Klapetek. Repository: kiconthemes Description --- According to table 2 in the icon theme spec, the Context per directory key is optional, and the Type key defaults to Threshold if not specified. Let's make the code do the same. Diffs - src/kicontheme.cpp 4f0e522 Diff: https://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124105: Adhere a bit better to the spec
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review81499 --- Could you please describe (or code) a test case? Or point to a bug report? - Christoph Feck On June 15, 2015, 7:30 p.m., Sune Vuorela wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/ --- (Updated June 15, 2015, 7:30 p.m.) Review request for KDE Frameworks, David Faure and Martin Klapetek. Repository: kiconthemes Description --- According to table 2 in the icon theme spec, the Context per directory key is optional, and the Type key defaults to Threshold if not specified. Let's make the code do the same. Diffs - src/kicontheme.cpp 4f0e522 Diff: https://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120380: Fix CMakeLists.txt to pass KDESU_USE_SUDO_DEFAULT to the compilation so it is used by suprocess.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120380/ --- (Updated June 15, 2015, 6:19 a.m.) Review request for KDE Frameworks. Changes --- use option() Repository: kdesu Description --- output note describing -DKDESU_USE_SUDO_DEFAULT=true Diffs (updated) - src/CMakeLists.txt aaa5ab2 Diff: https://git.reviewboard.kde.org/r/120380/diff/ Testing --- compiled, installed and ran kdesu, takes my user password instead of root Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120380: Fix CMakeLists.txt to pass KDESU_USE_SUDO_DEFAULT to the compilation so it is used by suprocess.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120380/#review81475 --- +1 - Aleix Pol Gonzalez On June 15, 2015, 8:19 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120380/ --- (Updated June 15, 2015, 8:19 a.m.) Review request for KDE Frameworks. Repository: kdesu Description --- output note describing -DKDESU_USE_SUDO_DEFAULT=true Diffs - src/CMakeLists.txt aaa5ab2 Diff: https://git.reviewboard.kde.org/r/120380/diff/ Testing --- compiled, installed and ran kdesu, takes my user password instead of root Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120380: Fix CMakeLists.txt to pass KDESU_USE_SUDO_DEFAULT to the compilation so it is used by suprocess.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120380/ --- (Updated June 15, 2015, 7:08 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0fa8ce7e1d25a57cd7992ccb33e659d46545683e by Jonathan Riddell to branch master. Repository: kdesu Description --- output note describing -DKDESU_USE_SUDO_DEFAULT=true Diffs - src/CMakeLists.txt aaa5ab2 Diff: https://git.reviewboard.kde.org/r/120380/diff/ Testing --- compiled, installed and ran kdesu, takes my user password instead of root Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
