Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated July 2, 2015, 8:19 a.m.) Review request for KDE Frameworks.

Re: Review Request 124129: Fix KAuthorized config file loading

2015-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124129/#review81980 --- Sorry, but the commit log makes no sense at all.

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review81983 --- +1, looks good src/kidletime.cpp (lines 173 - 180)

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review81979 --- +1 - Aleix Pol Gonzalez On July 2, 2015, 8:19 a.m., Martin

Re: Review Request 124147: Create Data Dir If it Does Not Exist

2015-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/#review81981 --- src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 50)

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review81982 --- The plugin for Wayland on top of this change is now

Future Frameworks Release BoF at Akademy

2015-07-02 Thread Kevin Ottens
Hello, Since the discussion on mailing lists regarding the Future frameworks releases thread couldn't get to a proper conclusion and we agreed on discussing the matter at Akademy, I took the liberty of scheduling a BoF session about it ASAP. The discussion is scheduled for Monday 27 July at

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2015-07-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Jul 2015 10:46:48 + Build duration: 4 min 4 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 124186: [runtime] Install headers and library for the private part

2015-07-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/ --- (Updated July 2, 2015, 11:40 a.m.) Status -- This change has been

Re: Review Request 124186: [runtime] Install headers and library for the private part

2015-07-02 Thread Martin Gräßlin
On July 1, 2015, 2:53 p.m., Martin Gräßlin wrote: Makes sense to me, I wonder whether we can make it actual public API, I guess we'll see if it's needed in the future anyway. I think it could be interesting to have it as public API if there are other environments to integrate with (I

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review81991 --- src/kidletime.cpp (line 173)

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review81992 --- A big +1! I like it :) - Mark Gaiser On jul 2, 2015, 12:14

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/ --- (Updated July 2, 2015, 2:14 p.m.) Review request for KDE Frameworks.

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review82001 --- src/kidletime.cpp (line 199)

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Martin Gräßlin
On July 2, 2015, 5:27 p.m., Aleix Pol Gonzalez wrote: src/kidletime.cpp, line 213 https://git.reviewboard.kde.org/r/124222/diff/2/?file=382226#file382226line213 qCDebug! There's no qCDebug usage in KIdleTime yet. That's why I kept it on qDebug. I don't mind changing to qCDebug,

Re: KEncodingProber vs unexisting codecs

2015-07-02 Thread Albert Astals Cid
El Dissabte, 6 de juny de 2015, a les 10:30:52, David Faure va escriure: On Sunday 24 May 2015 07:18:21 Albert Astals Cid wrote: One of the codecs that KEncodingProber can return is x-euc-tw But neither the Qt4 nor the Qt5 installed in my distribution understand that codec, so doing the

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

2015-07-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/ --- (Updated July 2, 2015, 5:23 p.m.) Status -- This change has been

Re: Review Request 124014: Add QQC clone of KColorButton

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review82011 --- Ship it! Ship It! - Kai Uwe Broulik On Juni 7, 2015, 7:30