Review Request 124549: Fix date+releaseinfo in frameworks/kservice docbooks

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124549/ --- Review request for Documentation, KDE Frameworks and David Faure.

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 23 - Still Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 13:26:10 + Build duration: 3 min 48 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 13:26:10 + Build duration: 3 min 40 sec CHANGE SET Revision

Review Request 124563: Make it possible to import/export shortcut schemes symmetrically

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/ --- Review request for KDE Frameworks and Alexander Dymo. Repository:

Review Request 124559: Update docbook in frameworks/kross

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124559/ --- Review request for Documentation, KDE Frameworks and Alexander Potashev.

Review Request 124560: Fix productname+releaseinfo in frameworks/kdesignerplugin docbook

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124560/ --- Review request for Documentation and KDE Frameworks. Repository:

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Aleix Pol Gonzalez
On July 31, 2015, 10:18 a.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 no-op? Kevin Funk wrote: Not a no-op, this code is written into cmake_install which is used for the 'install' target.

Re: Review Request 124563: Make it possible to import/export shortcut schemes symmetrically

2015-07-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/#review83244 --- +0.5 - Albert Astals Cid On jul. 31, 2015, 4:39 p.m.,

Review Request 124554: Update docbooks in frameworks/kio

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124554/ --- Review request for Documentation, KDE Frameworks and David Faure.

Review Request 124557: Fix method behavior KShortcutsEditorPrivate::importConfiguration

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124557/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 124557: Fix method behavior KShortcutsEditorPrivate::importConfiguration

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124557/ --- (Updated July 31, 2015, 3:49 p.m.) Status -- This change has been

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
On July 31, 2015, 8:18 a.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 no-op? Not a no-op, this code is written into cmake_install which is used for the 'install' target. If I don't add this line I

Review Request 124556: Fix date+releaseinfo in frameworks/kded docbook

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124556/ --- Review request for Documentation, KDE Frameworks and Àlex Fiestas.

Review Request 124562: Update + cleanup frameworks/kjsembed docbook

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124562/ --- Review request for Documentation, KDE Frameworks and Bernd Buschinski.

Re: Does frameworks allow move semantics unconditionally?

2015-07-31 Thread Alex Merry
On Friday 31 July 2015 15:11:56 Alex Merry wrote: So when you say move semantics, what does that encompass? You can use rvalue references in 2010 just fine, but someone would need to check that Qt detects that properly and provides appropriate overloads of various methods, and you may not get

Re: Review Request 124563: Make it possible to import/export shortcut schemes symmetrically

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/ --- (Updated July 31, 2015, 6:39 p.m.) Review request for KDE Frameworks and

Review Request 124552: Update docbooks in kdelibs4support

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124552/ --- Review request for Documentation and KDE Frameworks. Repository:

Re: Review Request 124557: Fix method behavior KShortcutsEditorPrivate::importConfiguration

2015-07-31 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124557/#review83241 --- Ship it! lgtm src/kshortcutseditor.cpp (line 603)

Re: Does frameworks allow move semantics unconditionally?

2015-07-31 Thread Alex Merry
On Friday 31 July 2015 19:15:55 Mark Gaiser wrote: Hi Alex, What i mean with move semantics are mainly the following features: - std::move - move copy constructor - move assignment operator I know std::move is in vs2010, i'm just not so sure about the move copy and assignment operator.

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Alex Merry
On July 31, 2015, 5:19 p.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 I can't see how setting a variable to itself can possibly change anything, or make any sense (other than an extremely weird

Review Request 124566: Update docbook in frameworks/kpackage

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124566/ --- Review request for Documentation, KDE Frameworks and Marco Martin.

Review Request 124567: Add missing date, releaseinfo + productname to kwallet-query.1.docbook

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124567/ --- Review request for Documentation, KDE Frameworks and Valentin Rusu.

Review Request 124568: Fix releaseinfo+productname, rm obsolet options in plasmapkg2 docbook

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124568/ --- Review request for Documentation, KDE Frameworks and Marco Martin.

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Luigi Toscano
On Lug. 31, 2015, 7:19 p.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 I can't see how setting a variable to itself can possibly change anything, or make any sense (other than an extremely weird

Re: Does frameworks allow move semantics unconditionally?

2015-07-31 Thread Mark Gaiser
On Fri, Jul 31, 2015 at 3:11 PM, Alex Merry alex.me...@kde.org wrote: On Thursday 30 July 2015 20:46:24 Mark Gaiser wrote: On Thu, Jul 23, 2015 at 9:59 PM, Mark Gaiser mark...@gmail.com wrote: Hi, The wiki page doesn't state it explicitly [1]. The status of move semantics when

Re: Does frameworks allow move semantics unconditionally?

2015-07-31 Thread Aleix Pol
On Thu, Jul 23, 2015 at 9:59 PM, Mark Gaiser mark...@gmail.com wrote: Hi, The wiki page doesn't state it explicitly [1]. The status of move semantics when searching for the status of N3053 on the compilers that frameworks support: GCC 4.6 [2] (frameworks requires 4.5) CLANG 3.0 [3]

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Alex Merry
On July 31, 2015, 5:19 p.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 I can't see how setting a variable to itself can possibly change anything, or make any sense (other than an extremely weird

Re: Review Request 124563: Make it possible to import/export shortcut schemes symmetrically

2015-07-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/#review83253 --- +1 - Mark Gaiser On jul 31, 2015, 4:39 p.m., Aleix Pol

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Alex Merry
On July 31, 2015, 8:18 a.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 no-op? Kevin Funk wrote: Not a no-op, this code is written into cmake_install which is used for the 'install' target.

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- (Updated July 31, 2015, 5:33 p.m.) Review request for Documentation, KDE

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
On July 31, 2015, 5:19 p.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 I can't see how setting a variable to itself can possibly change anything, or make any sense (other than an extremely weird

Re: Review Request 124554: Update docbooks in frameworks/kio

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124554/ --- (Updated July 31, 2015, 8:06 p.m.) Status -- This change has been

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 28 - Still Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 20:07:01 + Build duration: 4 min 53 sec CHANGE SET Revision

Re: Does frameworks allow move semantics unconditionally?

2015-07-31 Thread Mark Gaiser
On Fri, Jul 31, 2015 at 10:21 PM, Alex Merry alex.me...@kde.org wrote: On Friday 31 July 2015 21:27:45 Mark Gaiser wrote: So the one thing we know fairly certain right now is that MSVC 2012 is not going to be the deal breaker here. I'm still not 100% sure about GCC and Clang though..

Re: Does frameworks allow move semantics unconditionally?

2015-07-31 Thread Mark Gaiser
On Fri, Jul 31, 2015 at 7:50 PM, Aleix Pol aleix...@kde.org wrote: On Thu, Jul 23, 2015 at 9:59 PM, Mark Gaiser mark...@gmail.com wrote: Hi, The wiki page doesn't state it explicitly [1]. The status of move semantics when searching for the status of N3053 on the compilers that

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 20:12:08 + Build duration: 4 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 32 - Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 20:18:41 + Build duration: 11 min CHANGE SET Revision 0bdc71071474102a8b3afad7e11192e42508b7ac by

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 32 - Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 20:18:41 + Build duration: 11 min CHANGE SET Revision 0bdc71071474102a8b3afad7e11192e42508b7ac by

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83249 --- src/CMakeLists.txt (line 20)

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Alex Merry
On July 31, 2015, 5:19 p.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 I can't see how setting a variable to itself can possibly change anything, or make any sense (other than an extremely weird

Jenkins-kde-ci: ktexteditor master kf5-minimum » Linux,gcc - Build # 12 - Still Failing!

2015-07-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-minimum/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 07:48:09 + Build duration: 19 sec CHANGE SET Revision

Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Jenkins-kde-ci: ktexteditor master kf5-minimum » Linux,gcc - Build # 13 - Still Failing!

2015-07-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-minimum/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 07:59:35 + Build duration: 20 sec CHANGE SET Revision

Re: Review Request 124531: Fix date+releaseinfo in frameworks/kdoctools docbooks

2015-07-31 Thread Burkhard Lück
On Juli 31, 2015, 10:19 vorm., Aleix Pol Gonzalez wrote: docs/checkXML5/man-checkXML5.1.docbook, line 10 https://git.reviewboard.kde.org/r/124531/diff/2/?file=388810#file388810line10 When's that date? 2014-03-04 is the date of the last update of the docbook - Burkhard

CI Failures

2015-07-31 Thread David Faure
On Friday 31 July 2015 04:25:53 no-re...@kde.org wrote: GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-minimum/PLATFORM=Linux,compiler=gcc/1/ rsync: change_dir

Re: CI Failures

2015-07-31 Thread Albert Astals Cid
El Divendres, 31 de juliol de 2015, a les 20:57:37, Ben Cooksley va escriure: On Fri, Jul 31, 2015 at 8:14 PM, David Faure fa...@kde.org wrote: On Friday 31 July 2015 04:25:53 no-re...@kde.org wrote: GENERAL INFO BUILD FAILURE Build URL:

Re: Review Request 124542: CMake fixes for Windows build

2015-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83214 --- This is not ideal indeed, because URIs usually contain a real

Re: CI Failures

2015-07-31 Thread Ben Cooksley
On Fri, Jul 31, 2015 at 8:14 PM, David Faure fa...@kde.org wrote: On Friday 31 July 2015 04:25:53 no-re...@kde.org wrote: GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-minimum/PLATFORM=Linux,compiler=gcc/1/ rsync: change_dir

Re: Review Request 124531: Fix date+releaseinfo in frameworks/kdoctools docbooks

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124531/ --- (Updated Juli 31, 2015, 10:14 vorm.) Review request for Documentation,

Re: Review Request 124531: Fix date+releaseinfo in frameworks/kdoctools docbooks

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124531/#review83221 --- Ship it! docs/checkXML5/man-checkXML5.1.docbook (line 10)

Re: CI Failures

2015-07-31 Thread Scarlett Clark
As Ben stated bo patches. I will turn off kf5-minimum until I get back home and,we can all agree on a solution. Cheers Scarlett On Jul 31, 2015 11:28 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 31 de juliol de 2015, a les 20:57:37, Ben Cooksley va escriure: On Fri, Jul 31, 2015