Review Request 124578: Fix deprecated KRun::run call

2015-08-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124578/ --- Review request for KDE Frameworks and Antonis Tsiapaliokas. Repository:

Re: Review Request 124567: Add missing date, releaseinfo + productname to kwallet-query.1.docbook

2015-08-01 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124567/#review83293 --- Ship it! Ship It! - Valentin Rusu On July 31, 2015, 6:28

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:09:43 + Build duration: 3 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:44:49 + Build duration: 2 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:44:49 + Build duration: 2 min 13 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:55:16 + Build duration: 4 min 2 sec CHANGE SET Revision

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 12 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 13:19:05 + Build duration: 1 min 0 sec CHANGE SET Revision 2139246a43be350f12d2084dfb3cd29f7bc136ca

Re: kdeclarative test still broken

2015-08-01 Thread Albert Astals Cid
El Dissabte, 1 d'agost de 2015, a les 10:55:48, David Faure va escriure: Hello, this is your friendly unit test police... Are the files for the test missing? Seems to reference some resizemodeitem.qml and error1.qml that I can't find on the repo. Cheers, Albert On Friday 31 July 2015

Re: Does frameworks allow move semantics unconditionally?

2015-08-01 Thread Milian Wolff
On Friday, July 31, 2015 07:15:55 PM Mark Gaiser wrote: On Fri, Jul 31, 2015 at 3:11 PM, Alex Merry alex.me...@kde.org wrote: On Thursday 30 July 2015 20:46:24 Mark Gaiser wrote: On Thu, Jul 23, 2015 at 9:59 PM, Mark Gaiser mark...@gmail.com wrote: Hi, The wiki page doesn't state

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:15:08 + Build duration: 4 min 14 sec CHANGE SET Revision

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 12 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:12:18 + Build duration: 1 min 22 sec CHANGE SET Revision

Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:12:13 + Build duration: 1 min 53 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:15:08 + Build duration: 12 min CHANGE SET Revision baf8245f60abf7952c1fb10624cab15ad5f4d6ea by

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:15:08 + Build duration: 12 min CHANGE SET Revision baf8245f60abf7952c1fb10624cab15ad5f4d6ea by

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:19:58 + Build duration: 1 min 11 sec CHANGE SET Revision

Re: Review Request 124533: Update book and man page templates

2015-08-01 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124533/#review83295 --- Ship it! Thanks! - Luigi Toscano On Ago. 1, 2015, 9:41

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:59:32 + Build duration: 11 min CHANGE SET Revision 2fd24c562e3bd72bdb393497bbc03c10515bbc95

Re: kdeclarative test still broken

2015-08-01 Thread David Faure
On Saturday 01 August 2015 12:56:57 Albert Astals Cid wrote: Are the files for the test missing? Seems to reference some resizemodeitem.qml and error1.qml that I can't find on the repo. Yep, exactly. The data subdir is missing, probably a missing `git add`. -- David Faure,

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 11:44:28 + Build duration: 3 min 47 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 23 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 11:44:28 + Build duration: 3 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:55:09 + Build duration: 1 min 31 sec CHANGE SET Revision

Re: Review Request 124578: Fix deprecated KRun::run call

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124578/#review83288 --- Ship it! Yep, looks good.

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 53 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/53/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 01 Aug 2015 11:47:03 + Build duration: 2 min 14 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 53 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/53/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 01 Aug 2015 11:47:03 + Build duration: 2 min 14 sec CHANGE SET Revision

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 13:18:19 + Build duration: 3 min 11 sec CHANGE SET Revision

kemoticons unittests broken

2015-08-01 Thread David Faure
Hello Andreas, in commit 6fa213952ed0a7eee18a90c4f326d9312027788a you changed the default theme in kemoticons. Did you check that unittets still pass? https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/console Please look into fixing the unit tests as soon

Re: Review Request 124578: Fix deprecated KRun::run call

2015-08-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124578/ --- (Updated Aug. 1, 2015, 11:44 a.m.) Status -- This change has been

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 11 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:19:58 + Build duration: 2 min 33 sec CHANGE SET Revision

Re: kemoticons unittests broken

2015-08-01 Thread kainz.a
Hi, I have no glue how I can fix it, could you please look into the problem. thanks Andreas Kainz 2015-08-01 20:32 GMT+02:00 David Faure fa...@kde.org: Hello Andreas, in commit 6fa213952ed0a7eee18a90c4f326d9312027788a you changed the default theme in kemoticons. Did you check that

Re: Review Request 124542: CMake fixes for Windows build

2015-08-01 Thread Dāvis Mosāns
On Aug. 2, 2015, 12:35 a.m., Kevin Funk wrote: Looking back at the review which introduced the escaping, namely https://git.reviewboard.kde.org/r/120648/ , I escaped the comma as well in the first review. I don't remember why I removed them. Apart from that usage, comma are invalid

Review Request 124584: Introduce categorized debug output

2015-08-01 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124584/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:09:43 + Build duration: 3 min 34 sec CHANGE SET Revision

Re: Review Request 124531: Fix date+releaseinfo in frameworks/kdoctools docbooks

2015-08-01 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124531/#review83296 --- Ship it! Inviala! - Luigi Toscano On Lug. 31, 2015, 12:14

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 12:59:32 + Build duration: 11 min CHANGE SET Revision 2fd24c562e3bd72bdb393497bbc03c10515bbc95

Re: kemoticons unittests broken

2015-08-01 Thread kainz.a
I will have a look, but the problem is that the artist freeze is in a few days and I have to push some updates for the icon set and also have to make some new icons so if you work on that, it would be really nice. When I have time I will have a look and will see how kde will make the tests.

Re: kemoticons unittests broken

2015-08-01 Thread David Faure
On Saturday 01 August 2015 21:04:38 kainz.a wrote: Hi, I have no glue how I can fix it, could you please look into the problem. It's not that hard, you ensure the test is compiled (pass -DBUILD_TESTING=TRUE to cmake) then you run the test (cd autotest ; ./kemoticons-kemoticontest) then you

Re: kemoticons unittests broken

2015-08-01 Thread David Faure
On Saturday 01 August 2015 21:32:39 David Faure wrote: So this is likely just a case of updating the expected values in git. ... or maybe a better idea: forcing the unittests to use breeze, so that they don't depend on the choice of default theme... -- David Faure, fa...@kde.org,

Re: Review Request 124542: CMake fixes for Windows build

2015-08-01 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83305 --- cmake/uriencode.cmake (line 37)

Re: Review Request 124533: Update book and man page templates

2015-08-01 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124533/ --- (Updated Aug. 1, 2015, 7:41 vorm.) Review request for Documentation, KDE

Re: Review Request 124563: Make it possible to import/export shortcut schemes symmetrically

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/#review83274 --- Ship it! Very nice. Maybe KDevelop can finally provide a

Re: Review Request 124562: Update + cleanup frameworks/kjsembed docbook

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124562/#review83275 --- Ship it! Ship It! - David Faure On July 31, 2015, 4:17

Re: Review Request 124560: Fix productname+releaseinfo in frameworks/kdesignerplugin docbook

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124560/#review83276 --- Ship it!

Re: Review Request 124559: Update docbook in frameworks/kross

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124559/#review83277 --- Ship it! Ship It! - David Faure On July 31, 2015, 3:48

Re: Review Request 124556: Fix date+releaseinfo in frameworks/kded docbook

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124556/#review83278 --- Ship it! docs/kded5/man-kded5.8.docbook (line 28)

Re: Review Request 124552: Update docbooks in kdelibs4support

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124552/#review83279 --- docs/kdebugdialog5/index.docbook (line 38)

Re: Review Request 124569: Fix date+releaseinfo in preparetips docbook

2015-08-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124569/#review83280 --- Ship it! Ship It! - David Faure On July 31, 2015, 6:58

Re: Review Request 124562: Update + cleanup frameworks/kjsembed docbook

2015-08-01 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124562/ --- (Updated Aug. 1, 2015, 8:25 a.m.) Status -- This change has been

Re: Review Request 124569: Fix date+releaseinfo in preparetips docbook

2015-08-01 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124569/ --- (Updated Aug. 1, 2015, 8:28 a.m.) Status -- This change has been

Re: Review Request 124559: Update docbook in frameworks/kross

2015-08-01 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124559/ --- (Updated Aug. 1, 2015, 8:32 a.m.) Status -- This change has been

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

2015-08-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 08:32:37 + Build duration: 1 min 54 sec CHANGE SET Revision

kdeclarative test still broken

2015-08-01 Thread David Faure
Hello, this is your friendly unit test police... On Friday 31 July 2015 13:29:53 no-re...@kde.org wrote: Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ That one is a real test failure. The data dir is missing. Marco: I already emailed you

Review Request 124577: Fix Windows build

2015-08-01 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124577/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Re: Review Request 124577: Fix Windows build

2015-08-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124577/#review83283 --- Ship it! Ship It! - Martin Klapetek On Aug. 1, 2015,

Re: Review Request 124577: Fix Windows build

2015-08-01 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124577/ --- (Updated Aug. 1, 2015, 9:34 a.m.) Status -- This change has been

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 27 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 09:51:08 + Build duration: 3 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 09:51:13 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2015-08-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 01 Aug 2015 09:51:13 + Build duration: 10 min CHANGE SET Revision